Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code runs on a single container, added input capability #16

Merged
merged 5 commits into from Jul 27, 2022
Merged

Code runs on a single container, added input capability #16

merged 5 commits into from Jul 27, 2022

Conversation

ashirrwad
Copy link
Member

  1. Switched execution method, all the code now runs on a the same container.
  2. Added input capability.
  3. Fixed Capture compiler error #13, Compiler error is being displayed.
  4. Fixed Preserve new line special character from Fortran program output #14, Line breaks are being rendered.

@ashirrwad ashirrwad mentioned this pull request Jul 19, 2022
Closed
@ashirrwad
Copy link
Member Author

@milancurcic @everythingfunctional

everythingfunctional
everythingfunctional approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@everythingfunctional everythingfunctional left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I tried it out and it seems to work.

milancurcic
milancurcic approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@milancurcic milancurcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it looks OK, I think we can go forward pending any outstanding comments.

Backend/app.py
Comment on lines +20 to +23
Fortran_file = open("./File.f90", "w+")
Fortran_file.write(code)
program_input = open("./program_input.txt", "w+")
program_input.write(input)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and elsewhere: should we not clean up after writing, i.e.:

with open("./File.f90", "w+") as f:
    f.write(code)

@ashirrwad
Copy link
Member Author

Can we go ahead and merge this?

@everythingfunctional
Copy link
Member

Sure. I'll open an issue regarding @milancurcic 's comment.

@everythingfunctional everythingfunctional merged commit 3c2553f into fortran-lang:main Jul 27, 2022
@everythingfunctional everythingfunctional mentioned this pull request Jul 27, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everythingfunctional everythingfunctional everythingfunctional approved these changes

@milancurcic milancurcic milancurcic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preserve new line special character from Fortran program output Capture compiler error
3 participants
@ashirrwad @everythingfunctional @milancurcic