Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitignore to stdlib-fpm deployment for generated test files #766

Closed
minhqdao opened this issue Feb 7, 2024 · 1 comment · Fixed by #769
Closed

Add .gitignore to stdlib-fpm deployment for generated test files #766

minhqdao opened this issue Feb 7, 2024 · 1 comment · Fixed by #769
Labels
idea Proposition of an idea and opening an issue to discuss it

Comments

@minhqdao
Copy link
Contributor

minhqdao commented Feb 7, 2024

Motivation

A number of .txt,.bin, .dat and .stream files are created when running tests with fpm test on the stdlib-fpm branch. However, a .gitignore file is missing so the files end up cluttering the git diff and need to be manually deleted every time. While most of the development work will be done from the master branch, I think it is useful to be able to switch to the stdlib-fpm branch to try things out.

Prior Art

There is a .gitignore file on the master(branch name also needs change?) branch so some entries can be copied over during deployment.

Additional Information

I believe it would be more advantageous to avoid placing any files generated by tests directly in the project's root directory. Instead, they could be stored, for instance, in a build/test or tmp/test folder (open for suggestions). However, I acknowledge that for the time being, adding a .gitignore file is the simplest solution.

@minhqdao minhqdao added the idea Proposition of an idea and opening an issue to discuss it label Feb 7, 2024
@minhqdao minhqdao linked a pull request Feb 7, 2024 that will close this issue
@perazz
Copy link
Contributor

perazz commented Feb 7, 2024

The stdlib-fpm is generated on deployment @minhqdao, please check back the details at https://github.com/fortran-lang/stdlib/blob/master/ci/fpm-deployment.sh

@minhqdao minhqdao changed the title Add .gitignore to stdlib-fpm branch for generated test files Add .gitignore to stdlib-fpm deployment for generated test files Feb 8, 2024
@minhqdao minhqdao linked a pull request Feb 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea Proposition of an idea and opening an issue to discuss it
Projects
None yet
2 participants