Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split the loadtxt qp tests and skip them on Win #65

Merged
merged 3 commits into from
Jan 2, 2020
Merged

Split the loadtxt qp tests and skip them on Win #65

merged 3 commits into from
Jan 2, 2020

Conversation

certik
Copy link
Member

@certik certik commented Jan 2, 2020

No description provided.

@certik
Copy link
Member Author

certik commented Jan 2, 2020

The print_array is duplicated a lot, but that will eventually be fixed by #40.

jvdp1
jvdp1 reviewed Jan 2, 2020
View reviewed changes
src/tests/loadtxt/test_loadtxt.f90 Outdated Show resolved Hide resolved
src/tests/loadtxt/test_loadtxt_qp.f90 Outdated Show resolved Hide resolved
src/tests/loadtxt/test_loadtxt_qp.f90 Outdated Show resolved Hide resolved
src/tests/loadtxt/test_savetxt_qp.f90 Outdated Show resolved Hide resolved
jvdp1
jvdp1 reviewed Jan 2, 2020
View reviewed changes
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that test_save.f90 has not been modified for qp.

certik and others added 2 commits January 2, 2020 11:17
@certik @jvdp1
Apply suggestions from code review
3e11abc 
Co-Authored-By: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
@certik
Only do qp in the test_*_qp.f90 tests
8497560
@certik
Copy link
Member Author

certik commented Jan 2, 2020

It seems that test_save.f90 has not been modified for qp.

I think it is now. Let me know.

@certik certik requested review from jvdp1 and zbeekman January 2, 2020 18:23
jvdp1
jvdp1 approved these changes Jan 2, 2020
View reviewed changes
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me

zbeekman
zbeekman approved these changes Jan 2, 2020
View reviewed changes
Copy link
Member

@zbeekman zbeekman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@certik certik merged commit 924ee54 into fortran-lang:master Jan 2, 2020
@certik certik deleted the quad branch January 2, 2020 19:01
@certik
Copy link
Member Author

certik commented Jan 2, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbeekman zbeekman zbeekman approved these changes

@jvdp1 jvdp1 jvdp1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@certik @zbeekman @jvdp1