Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid overflow in to_string for -huge(1)-1 #667

Merged
merged 1 commit into from Jul 22, 2022
Merged

Avoid overflow in to_string for -huge(1)-1 #667

merged 1 commit into from Jul 22, 2022

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Jul 21, 2022

Closes #666

@awvwgk awvwgk added the bug Something isn't working label Jul 21, 2022
@awvwgk awvwgk requested a review from a team July 21, 2022 08:43
jvdp1
jvdp1 approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for this fix.

zoziha
zoziha approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@zoziha zoziha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that that bug has been solved and the tests have passed, thanks for sharing.

@awvwgk awvwgk merged commit 9c4abca into fortran-lang:master Jul 22, 2022
@awvwgk awvwgk deleted the negative-overflow branch July 22, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvdp1 jvdp1 jvdp1 approved these changes

@zoziha zoziha zoziha approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

to_string overflows on -huge(1)-1
3 participants
@awvwgk @jvdp1 @zoziha