Add radix_sort #712
Merged
Add radix_sort #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvdp1
reviewed
May 7, 2023
Comment on lines
+438
to
+470
| pure module subroutine int8_radix_sort(array, reverse) | ||
| integer(kind=int8), dimension(:), intent(inout) :: array | ||
| logical, intent(in), optional :: reverse | ||
| end subroutine int8_radix_sort | ||
|
|
||
| pure module subroutine int16_radix_sort(array, work, reverse) | ||
| integer(kind=int16), dimension(:), intent(inout) :: array | ||
| integer(kind=int16), dimension(:), intent(inout), target, optional :: work | ||
| logical, intent(in), optional :: reverse | ||
| end subroutine int16_radix_sort | ||
|
|
||
| pure module subroutine int32_radix_sort(array, work, reverse) | ||
| integer(kind=int32), dimension(:), intent(inout) :: array | ||
| integer(kind=int32), dimension(:), intent(inout), target, optional :: work | ||
| logical, intent(in), optional :: reverse | ||
| end subroutine int32_radix_sort | ||
|
|
||
| pure module subroutine int64_radix_sort(array, work, reverse) | ||
| integer(kind=int64), dimension(:), intent(inout) :: array | ||
| integer(kind=int64), dimension(:), intent(inout), target, optional :: work | ||
| logical, intent(in), optional :: reverse | ||
| end subroutine int64_radix_sort | ||
|
|
||
| module subroutine sp_radix_sort(array, work, reverse) | ||
| real(kind=sp), dimension(:), intent(inout), target :: array | ||
| real(kind=sp), dimension(:), intent(inout), target, optional :: work | ||
| logical, intent(in), optional :: reverse | ||
| end subroutine sp_radix_sort | ||
|
|
||
| module subroutine dp_radix_sort(array, work, reverse) | ||
| real(kind=dp), dimension(:), intent(inout), target :: array | ||
| real(kind=dp), dimension(:), intent(inout), target, optional :: work | ||
| logical, intent(in), optional :: reverse |
There was a problem hiding this comment.
Could be part of a
fypploop.
stdlib defines xdp, qp, but no int128. While radix sort need int128 to support such width data type. Considering the difference between int8_radix_sort and other integer types, and integer array do not need target attribute. I think the current version is just ok.
jvdp1
reviewed
May 7, 2023
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Thank you for review. I have updated the code according to your comments. Here are the changes:
|
jvdp1
reviewed
May 14, 2023
jvdp1
reviewed
May 14, 2023
jvdp1
reviewed
May 14, 2023
jvdp1
reviewed
May 14, 2023
|
The specs file must also be updated (similar text to what is in the |
0382
commented
May 17, 2023
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
jvdp1
reviewed
May 20, 2023
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Co-authored-by: 0382 <18322825326@163.com>
jvdp1
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For build-in types, radix_sort is faster in most cases than compare based sort algorithm.