Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect intent of the variable "conflict" on hashmaps in document #739

Merged
merged 1 commit into from Sep 19, 2023
Merged

Fixed incorrect intent of the variable "conflict" on hashmaps in document #739

merged 1 commit into from Sep 19, 2023

Conversation

Daisuke897
Copy link
Contributor

In the source code, the intent of the variable "conflict" in the procedure "map_entry" is "out", whereas in the documentation it is "in".
I corrected it from "in" to "out" on the documentation.

module subroutine map_chain_entry(map, key, other, conflict)
!
! Inserts an entry innto the hash map
! Arguments:
!! map - the hash table of interest
!! key - the key identifying the entry
!! other - other data associated with the key
!! conflict - logical flag indicating whether the entry key conflicts
!! with an existing key
!
class(chaining_hashmap_type), intent(inout) :: map
type(key_type), intent(in) :: key
type(other_type), intent(in), optional :: other
logical, intent(out), optional :: conflict
end subroutine map_chain_entry

Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you @Daisuke897 for this fix.

@jvdp1 jvdp1 merged commit d379587 into fortran-lang:master Sep 19, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants