Added a procedure for getting all the keys in a hashmap #741
Conversation
doc/specs/stdlib_hashmaps.md
Outdated
| @@ -1148,6 +1154,9 @@ Procedures to modify the content of a map: | |||
|
|
|||
| Procedures to report the content of a map: | |||
|
|
|||
| * `map % get_all_keys( all_keys )` - Returns all the keys | |||
| presented in the map; | |||
There was a problem hiding this comment.
Should it be "present" or "presented"?
There was a problem hiding this comment.
I use "presented in" to mean "located in," "existing in," or "contained in" here.
I cannot answer whether "present" or "presented" is correct due to my poor English skills, so I need help to create a natural expression, especially a phrase referring to "keys in a hash map."
There was a problem hiding this comment.
@milancurcic Any idea how it should be written?
There was a problem hiding this comment.
@jvdp1
The following expression is used in the documentation of Map in Java:
keySet()
Returns a Set view of the keys contained in this map.
So, I would like to change "presented" to "contained" to follow this expression. I would appreciate your comments.
Thank you.
There was a problem hiding this comment.
@degawa "contained" sounds good to me. Please, go ahead!
There was a problem hiding this comment.
Thank you, @jvdp1, for giving me a supportive push forward.
I fixed the documentation for the get_all_keys and pushed it.
I would appreciate a review.
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
To add a procedure for getting all the keys in a hashmap, the subroutine
get_all_keysis added to the hashmap types.get_all_keysis implemented as a subroutine rather than a function to maintain consistency with the other procedures, especiallyget_other_data.The tasks done are summarized as follows:
hashmap_typechaining_hashmap_typeandopen_hashmap_type.closes #732