Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linalg.md and example_blas_gemv.f90 #797

Merged
merged 2 commits into from
Apr 13, 2024

Conversation

zoziha
Copy link
Contributor

@zoziha zoziha commented Apr 13, 2024

Description

  1. Linking relying on fpm.toml requires adding the link keyword within the [build] section.
  2. An error in the example_blas_gemv has been corrected.
    image

@zoziha zoziha requested review from perazz and jvdp1 April 13, 2024 03:35
Copy link
Contributor

@perazz perazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the suggested edit, thanks @zoziha.

Now that BLAS/LAPACK support is enabled with our local implementation, we will better address how to link against external libraries.
For CMake builds it will be easy (FindBLAS, FindLAPACK), but for fpm, there is no support yet and I think the best way to do it is to search for said libraries via metapackage.

This PR is cosmetic and I will merge if @jvdp1 also has no further comments.

doc/specs/stdlib_linalg.md Outdated Show resolved Hide resolved
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @zoziha for this PR. LGTM. It can be merged after @perazz 's suggestion has been considered

Co-authored-by: Federico Perini <federico.perini@gmail.com>
@perazz perazz merged commit 19f84ce into fortran-lang:master Apr 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants