Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gfortran linter regex cannot display certain failures #295

Closed
gnikit opened this issue Nov 19, 2021 · 0 comments · Fixed by #293
Closed

gfortran linter regex cannot display certain failures #295

gnikit opened this issue Nov 19, 2021 · 0 comments · Fixed by #293
Assignees
Labels

Comments

@gnikit
Copy link
Member

gnikit commented Nov 19, 2021

Describe the bug
The existing regex has a few crucial blind spots when it comes to error reporting.
It cannot capture any errors that are generated by the compiler for the validity of the arguments, the preprocessor includes, missing linting symbols, etc.

These errors take the form:

binary-name: severity: message

To Reproduce
adding invalid include directories in linterinclude dirs should yield a -Wmissing-include-dirs warning
similarly adding too many input arguments (you can achieve that by using massive glob patterns for includes '/usr/include/', '/usr/lib/') should throw a fatal error

gfortran: fatal error: cannot execute '/usr/lib/gcc/x86_64-linux-gnu/9/f951': execv: Argument list too long.

Expected behavior
capture errors

Screenshots
If applicable, add screenshots to help explain your problem.

Build info (please complete the following information):

  • OS: all
  • Extension Version: all
  • Visual Studio Code Version: all
@gnikit gnikit added the bug label Nov 19, 2021
@gnikit gnikit self-assigned this Nov 19, 2021
gnikit added a commit that referenced this issue Nov 19, 2021
and adds support for gfortran and ifort compilers

Fixes Rewrite settings interface #292
Fixes Add support for Intel and LLVM compilers #291
Fixes gfortran linter regex cannot display certain failures #295
gnikit added a commit that referenced this issue Nov 24, 2021
and adds support for gfortran and ifort compilers

Fixes Rewrite settings interface #292
Fixes Add support for Intel and LLVM compilers #291
Fixes gfortran linter regex cannot display certain failures #295
@gnikit gnikit linked a pull request Nov 24, 2021 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant