Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Former tribal getting hallucinations from powder #498

Closed
VEN0M5 opened this issue Jul 30, 2021 · 5 comments
Closed

Former tribal getting hallucinations from powder #498

VEN0M5 opened this issue Jul 30, 2021 · 5 comments

Comments

@VEN0M5
Copy link

VEN0M5 commented Jul 30, 2021

Round ID:550

Testmerges:N/A

Reproduction: Currently using healing powder when you have the formal tribal perk still gives you hallucinations, as the increased healing is also tied to the same trait as the trait triggering the hallucinations, I suspect I am not getting the increased healing effect as well. The former tribal perk do appear to be applied to my character as I can't use autolathes.

@Zembaflemba
Copy link
Contributor

Tested it on a local server. Characters who spawn in as a tribal proper are given the increased healing rate and no hallucinations, however those with the Former Tribal perk get the same healing rate as everyone else. Not sure if intended, but I'll see about putting a PR up that changes it.

@VEN0M5
Copy link
Author

VEN0M5 commented Aug 3, 2021

My guess is the add trait is done incorrectly

https://github.com/fortune13-ss13/Fortune13/blob/master/code/datums/traits/good.dm

@Zembaflemba
Copy link
Contributor

That's exactly what it is. The fix should be simple. I'll have a PR up once I'm done testing.

@Zembaflemba
Copy link
Contributor

#521

@Zembaflemba
Copy link
Contributor

The fix was finally merged this can be closed.

@VEN0M5 VEN0M5 closed this as completed Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants