callback function to notify that fetchInBatch is finished

forward · Jul 13, 2011 · ca3e4a9 · ca3e4a9
1 parent a890e5d
commit ca3e4a9
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/examples/test.js b/examples/test.js
@@ -11,6 +11,8 @@ var i = 1;
 hive.fetchInBatch(5, "SELECT * FROM weather_data where dated = '2011-07-02' limit 12", function(err, data) {
   console.log("SELECT * FROM weather_data where dated = '2011-07-02' limit 12");
   console.log(i++ + "th data:", data.toTSV());
+}, function() {
+  console.log("fetchInBatch completed")
 });
 
 hive.execute("DESCRIBE weather_data", function(err, data) {

diff --git a/node-hive.js b/node-hive.js
@@ -70,17 +70,18 @@ var hiveClient = function(config) {
       });
     },
 
-    fetchInBatch: function(batchSize, query, onCompletion) {
+    fetchInBatch: function(batchSize, query, onBatchCompletion, onCompletion) {
-      connect(onCompletion, function(client) {
+      connect(onBatchCompletion, function(client) {
         client.execute(query, function() {
           client.getSchema(function(schema) {
             var fetchBatch = function() {
               client.fetchN(batchSize, function(data) {
                 if(data.length > 0) {
-                  onCompletion(null, ResultSet.create(data, schema));
+                  onBatchCompletion(null, ResultSet.create(data, schema));
                   process.nextTick(fetchBatch);
                 } else {
                   client.closeConnection();
+                  if (onCompletion) onCompletion(null, null);
                 }
               });
             };

diff --git a/package.json b/package.json
@@ -3,7 +3,7 @@
   "contributors":["Jae Lee <jlee@yetitrails.com>", "Antonio Terreno <antonio.terreno@gmail.com>", "Andy Kent"],
   "name": "node-hive",
   "description": "Node Hive Client Library",
-  "version": "0.0.4",
+  "version": "0.0.5",
   "homepage": "https://github.com/forward/node-hive",
   "repository": {
     "type": "git",