Skip to content
This repository has been archived by the owner on Jun 28, 2019. It is now read-only.

colored gem is old and broken, maybe use colorize? #39

Closed
Tomtomgo opened this issue Feb 16, 2015 · 3 comments · Fixed by #42
Closed

colored gem is old and broken, maybe use colorize? #39

Tomtomgo opened this issue Feb 16, 2015 · 3 comments · Fixed by #42

Comments

@Tomtomgo
Copy link
Contributor

After running bundle update I get an issue with the colored gem:

SSHKit::Runner::ExecuteError: Exception while executing as moi@ec2-magicnumber.us-west-2.compute.amazonaws.com: no implicit conversion of Hash into String
/usr/local/rvm/gems/ruby-2.1.2@moi/gems/colored-1.2/lib/colored.rb:70:in `colorize'
/usr/local/rvm/gems/ruby-2.1.2@moi/gems/sshkit-1.6.1/lib/sshkit/color.rb:7:in `black'

It seems colored and colorized do kinda the same thing and now seem to be clashing.
The colored gem hasn't been updated in 5 years and doesn't allow issues to be made on the Github repo. Using colorize should be better, they do update regularly and do allow issues to be reported.

@Tomtomgo
Copy link
Contributor Author

I can confirm that colored and the latest (0.7.5) version of colorize are clashing, I reverted to using colorized 0.7.4 and boom, everything works again!

Still, might be good to change to colorize gem.

@Bladrak
Copy link

Bladrak commented Feb 19, 2015

I do reproduce this (thanks @Tomtomgo for the version to downgrade to). I second your thought on changing to colorize gem.

@andytinycat
Copy link
Contributor

I agree; I think the choice to use colored was a bad move when I originally wrote the gem.

If you've got time, a PR would be welcomed. If not, I'll get to it next week as I lack the bandwidth to do this now.

freakphp pushed a commit to freakphp/cap-ec2 that referenced this issue Feb 28, 2015
andytinycat added a commit that referenced this issue Mar 2, 2015
Fixes #39 - switched to colorize gem
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants