Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ejs support for include directive #19

Merged
merged 2 commits into from Dec 6, 2012
Merged

ejs support for include directive #19

merged 2 commits into from Dec 6, 2012

Conversation

nicjansma
Copy link
Contributor

I've updated the ejs dependency to the latest, 0.8.3 from 0.7.1. This is to support the ejs 'include' directive, which was added around 0.7.2.

To support this, we need to send in filename as an option to ejs so it knows the relative path for other includes.

@nicjansma nicjansma mentioned this pull request Nov 29, 2012
@niftylettuce
Copy link
Collaborator

@nicjansma thanks, looks great, can you please add example to Readme and /examples folder?

@nicjansma
Copy link
Contributor Author

Yup, Readme updated, package.json updated to new version, and examples folder updated.

niftylettuce added a commit that referenced this pull request Dec 6, 2012
ejs support for include directive
@niftylettuce niftylettuce merged commit a011802 into forwardemail:master Dec 6, 2012
@niftylettuce
Copy link
Collaborator

@nicjansma thank you 👍 great job, appreciate it!

p.s. how did you find out about this module?

@niftylettuce
Copy link
Collaborator

published v0.0.7 to npm

@nicjansma
Copy link
Contributor Author

https://github.com/andris9/Nodemailer recommended it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants