Run juice even without a stylesheet so <style> tag CSS can be inlined.

[trevordixon]

I have the same request as #35.

What I've done here allows me to do something like this:

<style>
  <% include ../shared-styles.css %>
</style>

so that multiple email templates share CSS that gets inlined by juice. I implemented this in a weird, lazy way, so I understand you probably won't want to merge it without some cleaning up.

Are you willing to support something like this or come up with a better way to share CSS?

[niftylettuce]

@trevordixon is this fix still wanted? i can pull in

[trevordixon]

I haven't worked on it for a while. It doesn't affect me much right now.

[ragulka]

Ah, I would very much like to see this merged. At the moment, I am including a css file, but it is not inlined.

[niftylettuce]

See #39 (comment)

[andrewjensen]

I wanted to add my support for this pull request. I fought with the email-templates module for an hour or two to have shared stylesheets before just requiring juice and coding around it. And like @ragulka said, this isn't about EJS, it's about the internal implementation of juice.

[niftylettuce]

@andrewjensen have you tested the commit trevordixon@1852c99 by @trevordixon? just want to be sure everything works and nothing breaks from it before I accept the PR and push to NPM

[andrewjensen]

@niftylettuce I haven't yet but I'll be able to test it on Monday.

[niftylettuce]

@jasonsims has this already been resolved?

[jasonsims]

It seems like there are two requests here:

1. Always run juice even if no style.less file is provided within the template
2. Allow for shared style sheets between templates

The first currently does not happen. On #L82, we only run juice if a stylesheet file was found. I'm not clear on why this would be useful.

The second should work as long as you include a style.less (or any supported CSS preprocessor extension) file within the template directory which includes the base stylesheet. An example setup would be:

| myProject/
|--  templates/
|----  baseStyle.less
|----  template01/
|------  html.hbs
|------  style.less  # Include the base css file: @import "../baseStyle.less";
|----  template02/
|------  html.hbs
|------  style.less  

@niftylettuce Do you think there is any action to take here? If so, we should close this and open as a bug since this PR has become stale.

[custa1200]

Any chance this will ever be resolved?

[jeduan]

@custa1200 this PR was for a very old version of this project. I'll take a PR if you want to take a stab at it