Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from aws-sdk v2 to @aws-sdk v3 #11

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

arthurlenoir
Copy link
Contributor

Checklist

  • [ X] I have ensured my pull request is not behind the main or master branch of the original repository.
  • [ X] I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • [X ] I have written a commit message that passes commitlint linting.
  • [X ] I have ensured that my code changes pass linting tests.
  • [X ] I have ensured that my code changes pass unit tests.
  • [ X] I have described my pull request and the reasons for code changes along with context if necessary.

@socket-security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
eslint 8.45.0...8.39.0 None +3/-2 4.22 MB eslintbot

@arthurlenoir
Copy link
Contributor Author

Hello @niftylettuce
what do you think about this pull request?

Thanks in advance! 🙏

@titanism titanism merged commit 84f3df5 into forwardemail:master Sep 6, 2023
2 checks passed
@titanism
Copy link
Contributor

titanism commented Sep 6, 2023

@arthurlenoir we published v4.0.1 to npm, if you want to try it out and let us know if it works?

https://github.com/forwardemail/nodemailer-base64-to-s3/releases/tag/v4.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants