Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arc: virt: Add second UART #62

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Conversation

abrodkin
Copy link
Member

@abrodkin abrodkin commented Dec 24, 2021

In some cases it's really useful to have more than 1 UART interface. For example:

  • Use one UART for debug output while the second for interaction with
    the virtual platform.
  • Use one of UART's as a mean for packet communication (i.e. SLIP)

That was originally requested by Zephyr users here: https://lists.zephyrproject.org/g/devel/message/8285

@ruuddw
Copy link
Member

ruuddw commented Dec 24, 2021

Thanks - modifications like adding some peripherals required recompiling qemu and can't be achieved with some command line arguments/configuration? This will require an update of the Zephyr SDK.

@abrodkin abrodkin added the enhancement New feature or request label Dec 26, 2021
abrodkin added a commit to abrodkin/sdk-ng that referenced this pull request Dec 26, 2021
This enables more use-cases, including separation of debug
output from interaction with the platform via serial port,
SLIP-based networking and probably much more.

Originally introduced here:
foss-for-synopsys-dwc-arc-processors/qemu#62

Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
abrodkin added a commit to foss-for-synopsys-dwc-arc-processors/zephyr that referenced this pull request Dec 26, 2021
This makes the second UART of ARC QEMU's "virt" platfrom available
in Zephyr. But please note to get it used corresponding change needs
to be applied to QEMU itself, see:
foss-for-synopsys-dwc-arc-processors/qemu#62

PR for Zephyr's SDK-NG is posted here:
zephyrproject-rtos/sdk-ng#422

Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
abrodkin added a commit to abrodkin/sdk-ng that referenced this pull request Dec 26, 2021
This enables more use-cases, including separation of debug
output from interaction with the platform via serial port,
SLIP-based networking and probably much more.

Originally introduced here:
foss-for-synopsys-dwc-arc-processors/qemu#62

Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
In some cases it's really useful to have more than 1 UART interface.
For example:
 * Use one UART for debug output while the second for interaction with
   the virtual platform.
 * Use one of UART's as a mean for packe communication (i.e. SLIP)

That was originally requested by Zephyr users here:
https://lists.zephyrproject.org/g/devel/message/8285

Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
@abrodkin
Copy link
Member Author

@cupertinomiranda please consider merging this one as we need that in Zephyr SDK!

@cupertinomiranda
Copy link

This will be merged when all of the recent changes get stabilized.

@cupertinomiranda cupertinomiranda merged commit 1a8c062 into master Feb 16, 2022
@cupertinomiranda
Copy link

Sorry for the delay. @abrodkin did not want to delete the branch which is in your name. Please do it so, if you think it is Ok.

@abrodkin abrodkin deleted the abrodkin-second-uart branch February 17, 2022 08:36
nashif pushed a commit to zephyrproject-rtos/zephyr that referenced this pull request Mar 24, 2022
This makes the second UART of ARC QEMU's "virt" platfrom available
in Zephyr. But please note to get it used corresponding change needs
to be applied to QEMU itself, see:
foss-for-synopsys-dwc-arc-processors/qemu#62

PR for Zephyr's SDK-NG is posted here:
zephyrproject-rtos/sdk-ng#422

Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
coreboot-org-bot pushed a commit to coreboot/zephyr-cros that referenced this pull request Mar 28, 2022
This makes the second UART of ARC QEMU's "virt" platfrom available
in Zephyr. But please note to get it used corresponding change needs
to be applied to QEMU itself, see:

PR for Zephyr's SDK-NG is posted here:

foss-for-synopsys-dwc-arc-processors/qemu#62
zephyrproject-rtos/sdk-ng#422
Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
GitOrigin-RevId: 35f53b8
Change-Id: I08a693f3b72b835b09bf4ba697b1e75b3140492f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/3552932
Tested-by: CopyBot Service Account <copybot.service@gmail.com>
Tested-by: Yuval Peress <peress@google.com>
Reviewed-by: Yuval Peress <peress@google.com>
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
Tested-by: Keith Short <keithshort@chromium.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants