Add feature checkbox #97

DenserMeerkat · 2023-12-14T23:13:00Z

Checkbox for Headers and Parameters #58

Added 2 lists in requestModel to hold the enabled bools for the checkboxes of headers and parameters.
Backwards compatible with old data model.
CheckBox look matches colorScheme in both themes.
Updated tests.
Implements the Checkbox feature mentioned in Improving User Experience: Relocating the "+ Add Parameter" Button and Introducing Checkbox Functionality for Parameter Management #58

lib/codegen/kotlin/okhttp.dart

lib/models/request_model.dart

lib/screens/home_page/editor_pane/details_card/request_pane/request_params.dart

lib/utils/http_utils.dart

test/utils/http_utils_test.dart

ashitaprasad · 2023-12-22T03:14:56Z

This is working well @DenserMeerkat
Just a few comments above which can addressed.

DenserMeerkat · 2023-12-22T15:22:19Z

This is working well @DenserMeerkat Just a few comments above which can addressed.

Thanks for the review @ashitaprasad
I've made the changes mentioned in the review and added tests.

ashitaprasad · 2023-12-25T15:56:46Z

lib/codegen/dart/http.dart

@@ -111,9 +111,9 @@ void main() async {
        }


enabled params are not being passed/used in http codegen.

ashitaprasad · 2023-12-25T16:23:39Z

lib/screens/home_page/editor_pane/details_card/request_pane/request_params.dart

-                    rows = [
-                      kNameValueEmptyModel,
-                    ];
+                    rows = [kNameValueEmptyModel];


Add , after the first item for singleton lists.

ashitaprasad · 2023-12-25T16:24:16Z

lib/screens/home_page/editor_pane/details_card/request_pane/request_headers.dart

-                    rows = [
-                      kNameValueEmptyModel,
-                    ];
+                    rows = [kNameValueEmptyModel];


Add , after the first item for singleton lists.

ashitaprasad · 2023-12-25T16:24:24Z

lib/screens/home_page/editor_pane/details_card/request_pane/request_headers.dart

-                      kNameValueEmptyModel,
-                    ];
+                    rows = [kNameValueEmptyModel];
+                    isRowEnabledList = [true];


Add , after the first item for singleton lists.

ashitaprasad · 2023-12-25T16:28:48Z

lib/utils/har_utils.dart

Do not directly use enabledRequestParams or enabledRequestHeaders in requestModelToHARJsonRequest as it is also used for data export purposes and these should only be used in code gens.
Just like exportMode add a new parameter bool useEnabled and by default it should be false.
The flag should be turned on only when this function is called via code generators.

If it is true, only then enabled fields should be used.

ashitaprasad · 2023-12-25T16:36:02Z

test/utils/convert_utils_test.dart

@@ -127,4 +127,39 @@ Easily manipulate and play around with request inputs like headers, query parame
      expect(padMultilineString(text1, 10), text1FirstLineNotPaddedExpected);
    });
  });
+


These tests are only for getEnabledRows, you will need to add more tests to test the added functionality in more detail.
You need to define 3-4 new models in test/request_models.dart that have list of enabled headers and params (separate & mix of both) and add relevant expected codes in the test/codegen files to ensure the generated codes are correct.

ashitaprasad · 2023-12-25T16:37:19Z

Hi @DenserMeerkat,
Thanks for updating the PR. I have reviewed it and added my comments.

ashitaprasad · 2023-12-27T08:09:53Z

test/request_models.dart

@@ -180,3 +180,91 @@ const requestModelDelete2 = RequestModel(
 }""",
  requestBodyContentType: ContentType.json,
 );
+
+/// Request model with enabled params
+const requestModelEnabledParams = RequestModel(


GET request models are named requestModelGet9 ..10 ..
The id should also be get9 ..10..
In the comments above the model we write the purpose.
Same goes for all the below models.
Also, they should be positioned where the last get request model ends.

ashitaprasad · 2023-12-27T08:10:32Z

test/request_models.dart

+  ],
+);
+
+/// Request model with enabled rows


Instead of rows write some enabled headers & URL parameters

ashitaprasad · 2023-12-27T08:11:22Z

test/request_models.dart

+  ],
+);
+
+/// Request model with disabled rows


Instead of with disabled rows write where all headers & URL parameters are disabled

ashitaprasad · 2023-12-27T08:14:53Z

test/codegen/curl_codegen_test.dart

@@ -100,6 +100,7 @@ void main() {
      expect(curlCodeGen.getCode(requestModelPost3, "https"), expectedCode);


For all tests cases .. as they are of GET request .. position them correctly.

ashitaprasad · 2023-12-27T08:16:24Z

Hi @DenserMeerkat I have added my comments above. Thanks!

DenserMeerkat · 2023-12-27T16:33:52Z

Thanks @ashitaprasad
For taking your time to review and add comments.
I've made the mentioned changes.

ashitaprasad · 2024-01-06T00:33:22Z

Thank you for the PR @DenserMeerkat 🥳
LGTM 🚀

DenserMeerkat added 3 commits December 15, 2023 04:08

CheckBox and Filtering

ce8a7dc

Update request_model_test.dart

92c610d

Update convert_utils.dart

862d6ec

animator added the under review label Dec 16, 2023

DenserMeerkat closed this Dec 16, 2023

DenserMeerkat reopened this Dec 16, 2023

ashitaprasad reviewed Dec 22, 2023

View reviewed changes

ashitaprasad added work in progress Dev team is already working on this issue and removed under review labels Dec 22, 2023

DenserMeerkat added 4 commits December 22, 2023 19:28

Merge branch 'foss42:main' into add-feature-checkbox

aceb4c9

fix: review changes

06f8cd7

chore: add test for getEnabledRows

72bc6a6

fix: setState

ba007ad

DenserMeerkat requested a review from ashitaprasad December 22, 2023 15:25

Update convert_utils_test.dart

d912d5f

ashitaprasad added under review and removed work in progress Dev team is already working on this issue labels Dec 23, 2023

ashitaprasad reviewed Dec 25, 2023

View reviewed changes

Merge branch 'main' into add-feature-checkbox

bdd63ea

ashitaprasad removed the under review label Dec 25, 2023

ashitaprasad reviewed Dec 25, 2023

View reviewed changes

ashitaprasad added the work in progress Dev team is already working on this issue label Dec 25, 2023

chore: add request_model tests

3fd0a19

DenserMeerkat requested a review from ashitaprasad December 27, 2023 06:55

ashitaprasad reviewed Dec 27, 2023

View reviewed changes

fix: renamed and moved tests

f74426f

DenserMeerkat requested a review from ashitaprasad December 27, 2023 16:34

Update pubspec.lock

5fddefd

ashitaprasad added under review and removed work in progress Dev team is already working on this issue labels Dec 29, 2023

Merge branch 'main' into add-feature-checkbox

c92cc4c

ashitaprasad merged commit e321e77 into foss42:main Jan 6, 2024

ashitaprasad mentioned this pull request Jan 6, 2024

Improving User Experience: Relocating the "+ Add Parameter" Button and Introducing Checkbox Functionality for Parameter Management #58

Closed

ashitaprasad removed the under review label Jan 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add feature checkbox #97

Add feature checkbox #97

DenserMeerkat commented Dec 14, 2023

ashitaprasad commented Dec 22, 2023

DenserMeerkat commented Dec 22, 2023

ashitaprasad Dec 25, 2023 •

edited

ashitaprasad Dec 25, 2023

ashitaprasad Dec 25, 2023

ashitaprasad Dec 25, 2023

ashitaprasad Dec 25, 2023

ashitaprasad Dec 25, 2023

ashitaprasad Dec 25, 2023

ashitaprasad commented Dec 25, 2023

ashitaprasad Dec 27, 2023

ashitaprasad Dec 27, 2023 •

edited

ashitaprasad Dec 27, 2023

ashitaprasad Dec 27, 2023

ashitaprasad commented Dec 27, 2023

DenserMeerkat commented Dec 27, 2023

ashitaprasad commented Jan 6, 2024

		@@ -100,6 +100,7 @@ void main() {
		expect(curlCodeGen.getCode(requestModelPost3, "https"), expectedCode);

Add feature checkbox #97

Add feature checkbox #97

Conversation

DenserMeerkat commented Dec 14, 2023

Checkbox for Headers and Parameters #58

ashitaprasad commented Dec 22, 2023

DenserMeerkat commented Dec 22, 2023

ashitaprasad Dec 25, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ashitaprasad commented Dec 25, 2023

Choose a reason for hiding this comment

ashitaprasad Dec 27, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ashitaprasad commented Dec 27, 2023

DenserMeerkat commented Dec 27, 2023

ashitaprasad commented Jan 6, 2024

ashitaprasad Dec 25, 2023 •

edited

ashitaprasad Dec 27, 2023 •

edited