Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extensions: fix extensions handling #246

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Conversation

drupol
Copy link
Collaborator

@drupol drupol commented Jun 29, 2023

Listing available extensions for a PHP derivations is currently broken.

Reasons are:

  1. Syntax errors
  2. Wrong way of handling extensions
  3. Missing upstream extension, not defined in here

Therefore, the idea behind this PR is to be able to list all the available extensions for any php derivations, without errors.

Doing (replace XX with the PHP version):

NIXPKGS_ALLOW_BROKEN=1 \
NIXPKGS_ALLOW_INSECURE=1 \
NIXPKGS_ALLOW_UNFREE=1 \
nix eval --json --impure --expr '(import ./.).packages.x86_64-linux.phpXX.extensions'

should not throw any error, just list the available extensions.

This PR:

@drupol drupol marked this pull request as ready for review June 29, 2023 07:11
pkgs/package-overrides.nix Outdated Show resolved Hide resolved
@drupol drupol force-pushed the fix-extensions-handling branch 4 times, most recently from eea0b3d to 5a41fbb Compare June 29, 2023 20:20
pkgs/package-overrides.nix Outdated Show resolved Hide resolved
pkgs/package-overrides.nix Outdated Show resolved Hide resolved
pkgs/package-overrides.nix Outdated Show resolved Hide resolved
pkgs/package-overrides.nix Outdated Show resolved Hide resolved
@drupol drupol merged commit eabc51c into master Jun 30, 2023
11 checks passed
@drupol drupol deleted the fix-extensions-handling branch June 30, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to list all extensions of a php derivation
2 participants