Skip to content

Commit

Permalink
feat(builders): improve ant name parsing
Browse files Browse the repository at this point in the history
  • Loading branch information
xizhao committed May 30, 2018
1 parent ec20967 commit 269a380
Showing 1 changed file with 12 additions and 4 deletions.
16 changes: 12 additions & 4 deletions builders/ant.go
Original file line number Diff line number Diff line change
Expand Up @@ -194,12 +194,20 @@ func locatorFromJar(path string) (module.Locator, error) {
// fall back to parsing file name
re := regexp.MustCompile("(-sources|-javadoc)?.jar$")
nameParts := strings.Split(re.ReplaceAllString(filepath.Base(path), ""), "-")
lenNameParts := len(nameParts)

parsedProjectName := nameParts[0]
parsedRevisionName := ""
var parsedProjectName string
var parsedRevisionName string

if len(nameParts) > 1 {
parsedRevisionName = nameParts[1]
if lenNameParts == 1 {
parsedProjectName = nameParts[0]
} else if lenNameParts > 1 {
parsedProjectName = strings.Join(nameParts[0:lenNameParts-1], "-")
parsedRevisionName = nameParts[lenNameParts-1]
}

if parsedProjectName == "" {
return module.Locator{}, errors.New("unable to parse jar file")
}

return module.Locator{
Expand Down

0 comments on commit 269a380

Please sign in to comment.