Skip to content

Commit

Permalink
Integration test slowness workaround (#1413)
Browse files Browse the repository at this point in the history
* Try installing 2.20.5 to see how performance is.

* Try installing with cachix again.

* Set build-users group.

* Delete custom script, cleanup workflow files.

* Fix shell-check lint.
  • Loading branch information
csasarak committed Apr 18, 2024
1 parent 554964d commit 3916ec8
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 112 deletions.
95 changes: 0 additions & 95 deletions .github/scripts/install-nix.sh

This file was deleted.

12 changes: 4 additions & 8 deletions .github/workflows/bench.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,10 @@ jobs:
sed 's/nixbld:x:\([[:digit:]]*\):$/nixbld:x:\1:nixbld-1,nixbld-2,nixbld-3/' /etc/group > group-changed
mv group-changed /etc/group
- name: run our custom nix install script
run : ./.github/scripts/install-nix.sh
shell: bash
env:
INPUT_NIX_PATH: "nixpkgs=channel:nixos-unstable"
INPUT_EXTRA_NIX_CONFIG: "build-users-group = nixbld"
INPUT_INSTALL_URL: ""
INPUT_INSTALL_OPTIONS: ""
- uses: cachix/install-nix-action@v25
with:
nix_path: nixpkgs=channel:nixos-unstable
extra_nix_config: "build-users-group = nixbld"

- name: Debugging information
run: |
Expand Down
12 changes: 4 additions & 8 deletions .github/workflows/integrations-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,10 @@ jobs:
sed 's/nixbld:x:\([[:digit:]]*\):$/nixbld:x:\1:nixbld-1,nixbld-2,nixbld-3/' /etc/group > group-changed
mv group-changed /etc/group
- name: run our custom nix install script
run : ./.github/scripts/install-nix.sh
shell: bash
env:
INPUT_NIX_PATH: "nixpkgs=channel:nixos-unstable"
INPUT_EXTRA_NIX_CONFIG: "build-users-group = nixbld"
INPUT_INSTALL_URL: ""
INPUT_INSTALL_OPTIONS: ""
- uses: cachix/install-nix-action@v25
with:
nix_path: nixpkgs=channel:nixos-unstable
extra_nix_config: "build-users-group = nixbld"

- name: Debugging information
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -94,4 +94,4 @@ jobs:
uses: sudo-bot/action-shellcheck@latest
with:
# https://github.com/koalaman/shellcheck#how-to-use
cli-args: "*.sh ./.github/scripts/*.sh"
cli-args: "*.sh"

0 comments on commit 3916ec8

Please sign in to comment.