Skip to content

Commit

Permalink
chore: fix typo comments, remove dead code
Browse files Browse the repository at this point in the history
  • Loading branch information
elldritch committed Apr 3, 2018
1 parent 2954eee commit 986f053
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 20 deletions.
20 changes: 1 addition & 19 deletions builders/builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,26 +4,8 @@ import (
"github.com/fossas/fossa-cli/module"
)

// A Builder is an implementation of functionality for different build systems.
type Builder interface {
// Initialize gathers build environment information and does build setup.
Initialize() error
// Build runs a best-effort attempt at building the module.
Build(m module.Module, force bool) error
// Analyze returns the dependencies of a module.
Analyze(m module.Module, allowUnresolved bool) ([]module.Dependency, error)

// IsBuilt checks whether a module has been built.
IsBuilt(m module.Module, allowUnresolved bool) (bool, error)

// IsModule takes a string like and returns whether it matches to elect this Builder.
IsModule(configKey string) (bool, error)
// DiscoverModules finds what modules are available for analysis in a given directory.
DiscoverModules(dir string) ([]module.Config, error)
}

// New instantiates a Builder given a ModuleType
func New(moduleType module.Type) Builder {
func New(moduleType module.Type) module.Builder {
switch moduleType {
case module.Bower:
return &BowerBuilder{}
Expand Down
2 changes: 1 addition & 1 deletion builders/maven.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ func (builder *MavenBuilder) Initialize() error {
return nil
}

// Build runs `mvn install -DskipTests -Drat.skip=trucould not removee` and cleans with `mvn clean`
// Build runs `mvn install -DskipTests -Drat.skip=true` and cleans with `mvn clean`
func (builder *MavenBuilder) Build(m module.Module, force bool) error {
mavenLogger.Debugf("Running Maven build: %#v %#v", m, force)

Expand Down

0 comments on commit 986f053

Please sign in to comment.