remove shouldFallback

analyzers/ruby/ruby.go

@@ -127,12 +127,10 @@ func (a *Analyzer) IsBuilt() (bool, error) {
 }
 
 func (a *Analyzer) Analyze() (graph.Deps, error) {
-	shouldFallback := true
 	strategy := "list-lockfile"
 
 	if a.Options.Strategy != "" {
 		strategy = a.Options.Strategy
-		shouldFallback = false
 	}
 
 	lockfilePath := a.lockfilePath()
@@ -145,41 +143,45 @@ func (a *Analyzer) Analyze() (graph.Deps, error) {
 	case "list-lockfile":
 		fallthrough
 	default:
-		lockfile, err := bundler.FromLockfile(lockfilePath)
-		if err != nil {
-			if !shouldFallback {
-				return graph.Deps{}, err
-			}
+		return a.bundlerListLockfileAnalyzerStrategy(lockfilePath)
+	}
+}
 
-			return a.lockfileAnalyzerStrategy(lockfilePath)
+func (a *Analyzer) bundlerListLockfileAnalyzerStrategy(lockfilePath string) (graph.Deps, error) {
+	lockfile, err := bundler.FromLockfile(lockfilePath)
+	if err != nil {
+		if a.Options.Strategy != "" {
+			return graph.Deps{}, err
 		}
 
-		gems, err := a.Bundler.List()
-		if err == nil {
-			imports, deps := FilteredLockfile(gems, lockfile)
+		return a.lockfileAnalyzerStrategy(lockfilePath)
+	}
 
-			return graph.Deps{
-				Direct:     imports,
-				Transitive: deps,
-			}, nil
-		}
+	gems, err := a.Bundler.List()
+	if err == nil {
+		imports, deps := FilteredLockfile(gems, lockfile)
 
-		if !shouldFallback {
-			return graph.Deps{}, err
-		}
+		return graph.Deps{
+			Direct:     imports,
+			Transitive: deps,
+		}, nil
+	}
 
-		deps, err := a.lockfileAnalyzerStrategy(lockfilePath)
+	if a.Options.Strategy != "" {
+		return graph.Deps{}, err
+	}
 
-		if err == nil {
-			return deps, err
-		}
+	deps, err := a.lockfileAnalyzerStrategy(lockfilePath)
 
-		if !shouldFallback {
-			return graph.Deps{}, err
-		}
+	if err == nil {
+		return deps, err
+	}
 
-		return a.bundlerListAnalyzerStrategy()
+	if a.Options.Strategy != "" {
+		return graph.Deps{}, err
 	}
+
+	return a.bundlerListAnalyzerStrategy()
 }
 
 func (a *Analyzer) bundlerListAnalyzerStrategy() (graph.Deps, error) {