Various improvements to install.sh #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Thiht
commented
Mar 17, 2018
Thiht
commented
- Fix Shellcheck warnings
- Ask for permission to writ /usr/local/bin
- Fix some issues from jpillora/installer
- Retrieve latest version
|
|
|
Thank you for this contribution! @ilikebits can you review? |
waldyrious
reviewed
Mar 19, 2018
install.sh
Outdated
| msg=$1 | ||
| echo "============" | ||
| echo "Error: $msg" 1>&2 | ||
| exit 1 | ||
| } | ||
|
|
||
| # This function will ask for root privileges before executing a command | ||
| # The goal is to allow the used to run this script as a normal user and | ||
| # to ash authorizations as needed |
There was a problem hiding this comment.
Some minor corrections:
- "allow the used to run" --> "allow the user to run"
- "to ash authorizations as needed" --> "to be asked for authorizations as needed"
|
Merging with admin override:
|
xizhao
added a commit
that referenced
this pull request
Mar 20, 2018
…ssas/fossa-cli into feat/support-gradle-root-deps * 'feat/support-gradle-root-deps' of https://github.com/fossas/fossa-cli: chore: Add TODOs, ignore third_party in autoconfig Various improvements to install.sh (#109)
meghfossa
pushed a commit
that referenced
this pull request
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.