[ANE-782] [ANE-890] Improves lexer for setup.py
#1191
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR,
setup.py
parsing, so fossa-cli does not throw terminal error, when line comments are encountered\
lexer intosetup.py
parsing, so fossa-cli does not throw terminal error, when\
are encountered - i.e. line joining in pythonAcceptance criteria
fossa-cli
does not thrown an error when line comments are encounteredfossa-cli
does not thrown an error when\
are used for line joiningTesting plan
git checkout master && git pull origin && git checkout fix/setup-py-comment-parsing && make install-dev
mkdir pr1191 && cd pr1191
touch setup.py
for line comment
for backslash
fossa-dev analyze -o
\
is used to join linesRisks
N/A
References
Checklist
docs/
.Changelog.md
. If this PR did not mark a release, I added my changes into an# Unreleased
section at the top..fossa.yml
orfossa-deps.{json.yml}
, I updateddocs/references/files/*.schema.json
. You may also need to update these if you have added/removed new dependency type (e.g.pip
) or analysis target type (e.g.poetry
).