[ANE-699] Analysis discovery filter should be applied prior to analysis #1194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR,
Currently, discovery path filters are applied at
walk'
, so we don't even discover the targets, but for non-production path filteringI did not choose this approach, as we still want to show that we intentionally skipped this discovered targets in scan summary. If,
we choose to apply non-production path filtering at
walk'
stage - users won't know why certain projects were skipped.Acceptance criteria
/docs
,.git/
, etc.) should not be analyzedTesting plan
Here is the directory structure (zip attached) for filesystem, and (sandbox/container.tar) for container.
sandbox.zip
. ├── Dockerfile ├── backend │ ├── docs │ │ └── reqs.txt │ └── util │ └── example │ └── reqs.txt ├── container.tar ├── docs │ └── app │ └── reqs.txt └── reqs.txt 7 directories, 6 files
git pull origin && git checkout feat/non-prod-path-discovery-filters && make install-dev
fossa-dev analyze <extracted-zip-dir> -o | jq
fossa-dev container analyze <extracted-zip-dir/container.tar> -o | jq
For both of this you should see only 1 source unit manifest for
reqs.txt
Risks
N/A
References
ANE-699
Checklist
docs/
.Changelog.md
. If this PR did not mark a release, I added my changes into an# Unreleased
section at the top..fossa.yml
orfossa-deps.{json.yml}
, I updateddocs/references/files/*.schema.json
. You may also need to update these if you have added/removed new dependency type (e.g.pip
) or analysis target type (e.g.poetry
).