[No Ticket] Fix "Property name is not allowed" error for RPM deps #1199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR should hopefully fix a tiny issue with the fossa-deps schema that's been bugging me for some time.
When using a
fossa-deps.yml
file with an RPM dependency, the "name" field would be deemed invalid.Acceptance criteria
No more squiggly red lines! Names are valid, and should be considered as such.
Testing plan
With JSON and YAML Schema Download enabled in VSC, create a
fossa-deps.yml
file with the following:Open the file in VSC, it should inform you that "Property
name
is not allowed"After checking out this branch, or downloading the
fossa-deps.schema.json
file:Risks
I'm not sure if I need to change anything else, can reviewers please confirm whether I need to modify any additional files to reflect the change?
I also don't know if this will actualy fix the issue! Tested locally, but unsure what needs to be done for the changes to propagate.
References
No references.
Checklist
docs/
.Changelog.md
. If this PR did not mark a release, I added my changes into an# Unreleased
section at the top..fossa.yml
orfossa-deps.{json.yml}
, I updateddocs/references/files/*.schema.json
. You may also need to update these if you have added/removed new dependency type (e.g.pip
) or analysis target type (e.g.poetry
).