Remove monorepo #1202
Remove monorepo #1202
Conversation
|
@zlav planning to resolve the conflict later, whenever I merge both my outstanding PRs. |
Changelog.md
Outdated
| @@ -1,5 +1,8 @@ | |||
| # FOSSA CLI Changelog | |||
|
|
|||
| ## v3.7.12 | |||
There was a problem hiding this comment.
Should we pair this PR with first-party license scanning and make the release 3.8? The deprecation of monorepo (breaking change) and a significant new feature seem like a good reason to bump the minor version.
There was a problem hiding this comment.
That works for me, as long as we're fine with waiting until the first-party license scanning is done
There was a problem hiding this comment.
Sounds good to me! I don't think there's anything else pressing, as long as we merge first-party license scanning before early next week then we should be all good.
There was a problem hiding this comment.
@spatten please just ping me (or feel free to just resolve conflicts & merge this PR) whenever that is done then!
There was a problem hiding this comment.
As discussed in slack, merging after all to make #1203 simpler.
Overview
Removes monorepo from FOSSA CLI, except in a couple places where we currently test for whether a project is monorepo before attempting to wait for its build or uploading a new scan.
Also removed:
fossa vpssubcommand.wigginsembedded binary.Acceptance criteria
Monorepo no longer exists in FOSSA CLI, and meanwhile everything else still works.
I'm relying on tests and the type system to prove the latter.
Testing plan
I built the project and was able to run a simple scan, otherwise relying on tests.
Risks
No users should be depending on this functionality any longer, so this should not be risky.
References
https://fossa.atlassian.net/browse/ANE-755
Checklist
docs/.Changelog.md. If this PR did not mark a release, I added my changes into an# Unreleasedsection at the top..fossa.ymlorfossa-deps.{json.yml}, I updateddocs/references/files/*.schema.json. You may also need to update these if you have added/removed new dependency type (e.g.pip) or analysis target type (e.g.poetry).