Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANE-1009] golang retract statement #1213

Merged
merged 2 commits into from
Jun 1, 2023
Merged

[ANE-1009] golang retract statement #1213

merged 2 commits into from
Jun 1, 2023

Conversation

meghfossa
Copy link
Contributor

Overview

This PR,

  • updates go.mod parser so, we don't fail when retract block exists

Acceptance criteria

  • go.mod parser does not fail when, retract block exists

Testing plan

Prereq

git checkout master && git pull origin && git checkout go-lang-parser
make install-dev
mkdir sandbox && cd sandbox && wget https://raw.githubusercontent.com/open-telemetry/opentelemetry-collector-contrib/d1bda6802bc94c9c6980e9d47265801b4c62458f/internal/aws/xray/go.mod

Current

fossa analyze --output # fails

With Change

fossa-dev analyze --output # passes

Risks

N/A

References

https://fossa.atlassian.net/browse/ANE-1009

Checklist

  • I added tests for this PR's change (or explained in the PR description why tests don't make sense).
  • If this PR introduced a user-visible change, I added documentation into docs/.
  • If this change is externally visible, I updated Changelog.md. If this PR did not mark a release, I added my changes into an # Unreleased section at the top.
  • If I made changes to .fossa.yml or fossa-deps.{json.yml}, I updated docs/references/files/*.schema.json. You may also need to update these if you have added/removed new dependency type (e.g. pip) or analysis target type (e.g. poetry).

@meghfossa meghfossa requested a review from a team as a code owner June 1, 2023 22:58
@meghfossa meghfossa requested a review from zlav June 1, 2023 22:58
@meghfossa meghfossa changed the title [Ane-1009] golang retract statement [ANE-1009] golang retract statement Jun 1, 2023
@meghfossa meghfossa enabled auto-merge (squash) June 1, 2023 23:00
Copy link
Member

@zlav zlav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Very thorough testing 🙌

@meghfossa meghfossa merged commit ea4c237 into master Jun 1, 2023
17 checks passed
@meghfossa meghfossa deleted the fix/go-lang-parser branch June 1, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants