Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(builders): #44 add Cocoapods integration with path data #130

Merged
merged 3 commits into from May 1, 2018

Conversation

anuccio1
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Apr 27, 2018

CLA assistant check
All committers have signed the CLA.

Dockerfile Outdated
@@ -48,6 +48,9 @@ RUN wget https://dl.google.com/android/repository/sdk-tools-linux-3859397.zip -O
sudo chmod -R 775 /opt/android-sdk
ENV PATH=$PATH:/opt/android-sdk/tools/bin ANDROID_HOME=/opt/android-sdk

# Install Cocoapods
RUN sudo gem install cocoapods
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pin the version of Cocoapods you're installing?

}

// Fetcher always returns pod for CocoapodsModule
func (m CocoapodsModule) Fetcher() string {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This stuff isn't needed with the new changes, I think.

module/types.go Outdated
@@ -98,6 +100,12 @@ func Parse(key string) (Type, error) {
case "bower":
return Bower, nil

// Cocoapods aliases
case "pod":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might also want to alias "ios".

@xizhao
Copy link
Contributor

xizhao commented Apr 27, 2018

Connecting this to #44

@xizhao xizhao changed the title added Cocoapods integration with path data feat(builders): #44 add Cocoapods integration with path data Apr 27, 2018
@xizhao
Copy link
Contributor

xizhao commented Apr 27, 2018

@anuccio1 Please update documentation in this repo as well as on http://docs.fossa.io/

@anuccio1 anuccio1 force-pushed the cocoapods-integration branch 2 times, most recently from 4cc5a4d to 3c6c19d Compare May 1, 2018 19:22
@elldritch elldritch merged commit 1e27f85 into master May 1, 2018
@elldritch elldritch deleted the cocoapods-integration branch June 1, 2018 05:02
meghfossa pushed a commit that referenced this pull request Nov 12, 2021
* Add carthage docs and ios table

* Remove bad space

* Add cocoapods docs.

* Remove tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants