New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(builders): #44 add Cocoapods integration with path data #130
Conversation
Dockerfile
Outdated
@@ -48,6 +48,9 @@ RUN wget https://dl.google.com/android/repository/sdk-tools-linux-3859397.zip -O | |||
sudo chmod -R 775 /opt/android-sdk | |||
ENV PATH=$PATH:/opt/android-sdk/tools/bin ANDROID_HOME=/opt/android-sdk | |||
|
|||
# Install Cocoapods | |||
RUN sudo gem install cocoapods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you pin the version of Cocoapods you're installing?
} | ||
|
||
// Fetcher always returns pod for CocoapodsModule | ||
func (m CocoapodsModule) Fetcher() string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This stuff isn't needed with the new changes, I think.
module/types.go
Outdated
@@ -98,6 +100,12 @@ func Parse(key string) (Type, error) { | |||
case "bower": | |||
return Bower, nil | |||
|
|||
// Cocoapods aliases | |||
case "pod": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might also want to alias "ios".
6fa5a49
to
219e3e9
Compare
Connecting this to #44 |
@anuccio1 Please update documentation in this repo as well as on http://docs.fossa.io/ |
4cc5a4d
to
3c6c19d
Compare
3c6c19d
to
9d75c3b
Compare
* Add carthage docs and ios table * Remove bad space * Add cocoapods docs. * Remove tags
No description provided.