Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: Add extra debug logging along Gradle analysis path #1360

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

elldritch
Copy link
Member

@elldritch elldritch commented Jan 11, 2024

Overview

This PR adds extra debug logging along the Gradle analysis path, to help solve user issues for ZD-7543.

Acceptance criteria

Enough logging to understand where dependencies are being filtered out.

Testing plan

I didn't, seems low risk, especially since the logging carrier explicitly ignores SevDebug when not in debug mode.

Risks

I'm worried about performance implications, but IgnoreDebugC seems to have already taken that into account.

References

Checklist

  • I added tests for this PR's change (or explained in the PR description why tests don't make sense).
  • If this PR introduced a user-visible change, I added documentation into docs/.
  • If this PR added docs, I added links as appropriate to the user manual's ToC in docs/README.ms and gave consideration to how discoverable or not my documentation is.
  • If this change is externally visible, I updated Changelog.md. If this PR did not mark a release, I added my changes into an # Unreleased section at the top.
  • If I made changes to .fossa.yml or fossa-deps.{json.yml}, I updated docs/references/files/*.schema.json AND I have updated example files used by fossa init command. You may also need to update these if you have added/removed new dependency type (e.g. pip) or analysis target type (e.g. poetry).
  • If I made changes to a subcommand's options, I updated docs/references/subcommands/<subcommand>.md.

@elldritch elldritch requested a review from a team as a code owner January 11, 2024 19:38
Copy link
Contributor

@csasarak csasarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving to not block since I think there's low risk here. But please have a look at my comments. Thanks for adding these!

src/App/Fossa/Analyze.hs Outdated Show resolved Hide resolved
src/App/Fossa/Analyze.hs Outdated Show resolved Hide resolved
@elldritch elldritch merged commit a48355e into master Jan 11, 2024
16 checks passed
@elldritch elldritch deleted the leo/debug/add-gradle-logging branch January 11, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants