-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds basic reachability integration in cli (Part 1/N) #1363
Conversation
pub struct Reachability {} | ||
|
||
impl Reachability { | ||
pub fn from_stdin() -> Result<Self> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have intentionally left out implementation. This will be added in second PR tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one question about the proliferation about error handling libraries that we use, but I don't think that's blocking.
Other than that, looks great!
simple_logger = { version = "4.3.3", features = ["stderr", "colors"], default-features = false } | ||
log = "0.4.17" | ||
snippets = { git = "https://github.com/fossas/lib-snippets", version = "0.2.0", features = ["lang-java-11"] } | ||
stable-eyre = "0.2.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm worried that we are using too many error handling libraries.
Broker uses error-stack
. Lernie and Sherlock use this-error
. Reachability-toolkit uses anyhow
.
Now we're adding eyre
into the mix.
If there's a good reason to use stable-eyre
instead of one of the other three, then that's fine. But I wanted to double-check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied the dependencies and code structure from berkelydb
, but I can modify it to recent rust code one's.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. Maybe we should merge this as-is, but have a quick conversation about whether we want to standardize this a bit in standup tomorrow.
I don't think it blocks this PR; we can just make the change later if we decide to
Superseded by: #1372 |
Overview
This is part of stack PR. This PR will not be merged, until all stacked PR's are merged into this branch.
This PR,
fossa reachability <PATH>
command for debuggingAcceptance criteria
fossa reachability <PATH>
can be executed (It will fail in part 1 PR)Testing plan
after which,
Risks
N/A
Metrics
N/A
References
N/A
Checklist
docs/
.docs/README.ms
and gave consideration to how discoverable or not my documentation is.Changelog.md
. If this PR did not mark a release, I added my changes into an# Unreleased
section at the top..fossa.yml
orfossa-deps.{json.yml}
, I updateddocs/references/files/*.schema.json
AND I have updated example files used byfossa init
command. You may also need to update these if you have added/removed new dependency type (e.g.pip
) or analysis target type (e.g.poetry
).docs/references/subcommands/<subcommand>.md
.