feat(go): Run go get on incomplete builds #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xizhao
requested changes
Jan 24, 2018
build/golang.go
Outdated
| if err != nil { | ||
| if opts["install"].(bool) { | ||
| log.Logger.Debug("Could not resolve some dependencies. Attempting to run build...") | ||
| exec.Command("go", "get", opts["entry-point"].(string)).Output() |
There was a problem hiding this comment.
use m.Manifest over opts["entry-point"]. The build command parses the opt and sets the module's manifest with it.
build/golang.go
Outdated
| if err != nil { | ||
| if opts["install"].(bool) { | ||
| log.Logger.Debug("Could not resolve some dependencies. Attempting to run build...") | ||
| exec.Command("go", "get", opts["entry-point"].(string)).Output() |
There was a problem hiding this comment.
exec.Command returns an error that we could handle. If this command fails, we could exit before calling resolveManifest again -- up to you.
build/golang.go
Outdated
| } | ||
|
|
||
| m.Build.RawDependencies = deps | ||
| m.Build.RawDependencies = resolvedDeps |
There was a problem hiding this comment.
We could call Dedupe() on this before returning
elldritch
force-pushed
the
feat/1-go-get
branch
from
ef4f27e
to
012ea89
Compare
elldritch
force-pushed
the
feat/1-go-get
branch
from
012ea89
to
b476866
Compare
xizhao
approved these changes
Jan 24, 2018
meghfossa
pushed a commit
that referenced
this pull request
Nov 12, 2021
meghfossa
added a commit
that referenced
this pull request
Mar 17, 2022
meghfossa
added a commit
that referenced
this pull request
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1.