feat(vcs): Correctly infer VCS settings when within a repo but not at the root #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elldritch
approved these changes
Aug 1, 2018
There was a problem hiding this comment.
It feels like the entire monad interface is very unwieldy in Go. It looks like this interface is only ever used for finding files or folders recursively in parents. What are your thoughts on removing package monad, and specialising this functionality to package files in a follow-on PR?
I'm also happy to pick up the monad refactor.
cli.go
Outdated
| // Package cli encompasses domain types for the CLI app. | ||
| package cli | ||
|
|
||
| // VCSType represents a type of version control system. |
monad/monad.go
Outdated
| Err error | ||
| } | ||
|
|
||
| // EitherVCSTypeFunc defines monadic EitherStr functions. |
There was a problem hiding this comment.
[nit] "defines monadic EitherVCSType functions".
vcs/vcs_test.go
Outdated
| "github.com/fossas/fossa-cli/vcs" | ||
| ) | ||
|
|
||
| func TestGetRepositoryBelowRoot(t *testing.T) { |
There was a problem hiding this comment.
Can you also add a test for being at the root?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #190.