Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coveralls support added #260

Merged
merged 2 commits into from
Sep 13, 2018
Merged

coveralls support added #260

merged 2 commits into from
Sep 13, 2018

Conversation

zlav
Copy link
Member

@zlav zlav commented Sep 13, 2018

goveralls is equivalent to go test and does not interfere with junit reporting
$(COVERALLS_TOKEN) is set in CircleCi's environment variables to avoid public exposure

@CLAassistant
Copy link

CLAassistant commented Sep 13, 2018

CLA assistant check
All committers have signed the CLA.

@zlav zlav requested a review from elldritch September 13, 2018 01:39
Copy link
Member

@elldritch elldritch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This was shockingly easy. Feel free to merge when ready!

@zlav zlav merged commit 42d448f into master Sep 13, 2018
@zlav zlav deleted the ci/coveralls branch September 13, 2018 21:43
meghfossa pushed a commit that referenced this pull request Nov 12, 2021
* move url deps to new section in fossa-deps

* Play type tetris

* docs update

* update tests

* Move optional fields into new metadata section

* copy updates

* changelog updates

Co-authored-by: Wesley Van Melle <van.melle.wes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants