Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmd): Correctly parse module options when passed from command line #393

Merged
merged 1 commit into from Jan 18, 2019

Conversation

elldritch
Copy link
Member

Would love if you could take this over and add a test (it's fine to test as a follow-on if this is time-critical to merge).

@elldritch elldritch requested a review from zlav January 8, 2019 20:50
Copy link
Member

@zlav zlav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a lot more sense to me after I started trying to write the code myself. Looks good to me, will add a test in a follow up PR.

@codecov
Copy link

codecov bot commented Jan 18, 2019

Codecov Report

Merging #393 into master will increase coverage by 0.04%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
+ Coverage   43.99%   44.04%   +0.04%     
==========================================
  Files          71       71              
  Lines        3448     3449       +1     
==========================================
+ Hits         1517     1519       +2     
+ Misses       1778     1777       -1     
  Partials      153      153
Impacted Files Coverage Δ
config/keys.go 39.21% <71.42%> (+1.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be61f55...d6bf429. Read the comment docs.

@zlav zlav merged commit cef13fe into master Jan 18, 2019
@zlav zlav deleted the fix/module-option-parsing-cmdline branch January 18, 2019 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants