fix (Gradle analyzer) Fix gradle discovery for root projects and add a flag to scan all submodules #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #399 +/- ##
==========================================
- Coverage 45.05% 44.97% -0.09%
==========================================
Files 76 76
Lines 3804 3811 +7
==========================================
Hits 1714 1714
- Misses 1915 1922 +7
Partials 175 175
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #399 +/- ##
==========================================
+ Coverage 45.05% 45.28% +0.23%
==========================================
Files 76 76
Lines 3804 3811 +7
==========================================
+ Hits 1714 1726 +12
+ Misses 1915 1909 -6
- Partials 175 176 +1
Continue to review full report at Codecov.
|
golangcibot
reviewed
Jan 19, 2019
config/keys_test.go
Outdated
| flagSet := flag.NewFlagSet("test", 0) | ||
| flags.ConfigF.Apply(flagSet) | ||
| flags.OptionF.Apply(flagSet) | ||
| flagSet.Parse([]string{"gradle:argumentmodule"}) |
There was a problem hiding this comment.
Error return value of flagSet.Parse is not checked (from errcheck)
meghfossa
added a commit
that referenced
this pull request
Nov 12, 2021
…sa-cli for coming migration (#399)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with how a module is constructed when a
build.gradlefile is discovered but no subprojects are present.This PR also adds support for scanning all of a projects submodules using the flag
--option allsubmodules:true. This is particularly useful when runningfossa analyzewith the argumentgradle::to signify a gradle root project.Steps for merging multiple projects dependency maps:
map[string]graph.Depsobject to hold all projects configuration mappings.graph.Depsfrom the specified configuration in the returnable map.