Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .fossa.yaml parsing + example config file #5

Merged
merged 5 commits into from
Jan 26, 2018
Merged

Conversation

elldritch
Copy link
Member

Follow-up work:

  • Refactor CLI build options to allow multiple entry points

@elldritch elldritch requested a review from xizhao January 24, 2018 22:38
APIKey string `yaml:"api_key"`
Server string
}
Analyze []struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would take advantage of the Module struct

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I agree. The configuration file is different enough (and will diverge enough) that I don't think it should use the same struct as the specific internal implementation of Module.

Code should prefer expressing semantic intent over saving on typing.

.fossa.yaml Outdated
api_key: some-key-here
# server: https://fossa.on-prem

analyze:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe rename to modules?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

.fossa.yaml Outdated
# type: bowerpackage

# These take a lot of inspiration from CircleCI
# build:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's docker? the build env?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for some foreseeable point in the future when we want to allow people to provide configuration to build on our agents. This is not meant for the CLI.

.fossa.yaml Outdated
@@ -0,0 +1,25 @@
cli:
api_key: some-key-here
# server: https://fossa.on-prem
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also need build repo opts like the project locator of the repo, so we can know what api endpoints to publish to

we somehow need to detect the revision of the CWD so we can build the full locator to publish to the api

fossa -l debug upload -k aa037953ac40cbbfbe321968297d302d --endpoint http://localhost:9578 --locator 'git+github.com/benjamn/recast$0297ae05d9ca5ae1aa5fc8a2b10262517f15cafe' '$(fossa -l debug build -t CommonJSPackage)' <-- this is my working test cmd rn

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Be aware that the current built "locator" DOES NOT normalise the project URL.

@xizhao xizhao merged commit 271ba79 into master Jan 26, 2018
@elldritch elldritch deleted the feat/4-fossa-yaml branch March 1, 2018 20:17
meghfossa pushed a commit that referenced this pull request Nov 12, 2021
Initial support for bundle show
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants