New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fossa upload-project command #639
Conversation
Codecov Report
@@ Coverage Diff @@
## master #639 +/- ##
==========================================
- Coverage 48.76% 48.41% -0.35%
==========================================
Files 117 117
Lines 6398 6446 +48
==========================================
+ Hits 3120 3121 +1
- Misses 2970 3016 +46
- Partials 308 309 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Some comments. Non-blocking due to urgency - please respond before merging, but don't feel like you need to block on a re-approval before merge.
Description
Add support for a
fossa upload-project
command that is intended to behave identically to the UI archive scanning feature.This PR also adds support to assign a project to a release group version from the CLI by supplying
--release-group <name>
and--release-group-version <version>
to the command.Example UI:
Notes
I considered using one flag and splitting on a special character such as
--release-group <name>@<version>
but I decided to implement two separate flags. The main reason is to avoid unintended issues with splitting the strings on the backend and disallowing a certain special character. The second reason is to reduce confusion for the user who needs to manually add the character. I am favoring enforcing explicit declaration over the expense of the command looking a bit messy.