Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve archive dependency scanning #643

Merged
merged 1 commit into from Jan 25, 2021
Merged

Improve archive dependency scanning #643

merged 1 commit into from Jan 25, 2021

Conversation

zlav
Copy link
Member

@zlav zlav commented Jan 25, 2021

Description

RawLicenseScan was a very unclear variable that led to unintended behavior with fossa upload-project. This PR improves the variable naming and fixes the logic with fossa upload-project

Acceptance Criteria

Variable naming is more clear and upload project works as intended (Scans project for dependencies on the backend)

Testing plan

I manually verified this worked with FOSSA cloud.

@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #643 (336e2a9) into master (b1e910a) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #643      +/-   ##
==========================================
- Coverage   48.42%   48.41%   -0.01%     
==========================================
  Files         117      117              
  Lines        6445     6446       +1     
==========================================
  Hits         3121     3121              
- Misses       3015     3016       +1     
  Partials      309      309              
Impacted Files Coverage Δ
analyzers/maven/maven.go 18.98% <0.00%> (-0.25%) ⬇️
api/fossa/tar.go 10.11% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1e910a...336e2a9. Read the comment docs.

@zlav zlav changed the title improve license scan fix Improve archive dependency scanning Jan 25, 2021
@zlav zlav merged commit 871e94f into master Jan 25, 2021
@zlav zlav deleted the fix/license-scan-only branch January 25, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants