Packagelock json bool resolved #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csasarak
force-pushed
the
packagelock-json-bool-resolved
branch
from
975503c
to
d2a7680
Compare
csasarak
force-pushed
the
packagelock-json-bool-resolved
branch
from
7ec4404
to
0d81b11
Compare
skilly-lily
approved these changes
Jan 20, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes a parser error when a
package-lock.jsondependency'sresolvedkey is a boolean rather than a string.Acceptance criteria
The parser for
package-lock.jsondependencies should ignore a booleanresolvedkey.Testing plan
I added unit tests for the dependency parser. I also manually ran
fossa analyzeagainst the repo referenced in #718 and verified that it now parses successfully.To reproduce you can run the master branch's
fossa analyzeagainst the repo in the above issue.Risks
References
Closes fossas/team-analysis#849
Closes #718
Checklist
docs/.Changelog.mdif this change is externally facing. If this PR did not mark a release, I added my changes into an# Unreleasedsection at the top.*schema.jsonif I have made changes for.fossa.yml,fossa-deps.{json, yaml, yml}. You may also need to update these if you have added/removed new dependency (e.g. pip) or analysis target type (e.g. poetry).