Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/fix builders config #82

Merged
merged 4 commits into from
Mar 3, 2018
Merged

Fix/fix builders config #82

merged 4 commits into from
Mar 3, 2018

Conversation

xizhao
Copy link
Contributor

@xizhao xizhao commented Mar 3, 2018

No description provided.

@xizhao xizhao requested a review from elldritch March 3, 2018 03:09
@@ -130,7 +130,7 @@ func (builder *GradleBuilder) DiscoverModules(dir string) ([]config.ModuleConfig
gradleTask := strings.Split(trimmed, " - ")[0]
gradleLogger.Debugf("found gradle dependencies task: %s", gradleTask)
moduleConfigurations = append(moduleConfigurations, config.ModuleConfig{
Name: strings.Split(gradleTask, ":")[0], // Name is the gradle task name
Name: strings.Split(gradleTask, ":")[0] + ":compile", // Name is the gradle task name + ":" + configuraiton (default to compile)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo.

@xizhao xizhao merged commit 7f4d52f into master Mar 3, 2018
@elldritch elldritch deleted the fix/fix-builders-config branch March 3, 2018 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants