Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Given the following perl manifest
META.yml
file, we report an error when parsing therequires
field:We expect the
Parse::Yapp
key (or any package name key) to have a textual version number, but here, it's an integer.We have run into this before, and we use the
TextLike
data type for accepting any oftext
,integer
, ordouble
datatypes in JSON and YAML parsers, and forcing them to become text.This PR uses the
TextLike
datatype for package version numbers in the perl analyzer.Acceptance criteria
Testing plan
Unit tests should be sufficient here.
Risks
None, the type system confirms that we have handled the text correctly until the transition point of
TextLike -> Text
, and the tests confirm the behavior is correct.Reviewer, please validate the changes to the test files, and ensure that without these changes, the tests would fail.
References
ZD 4387
Checklist
docs/
.Changelog.md
. If this PR did not mark a release, I added my changes into an# Unreleased
section at the top..fossa.yml
orfossa-deps.{json.yml}
, I updateddocs/references/files/*.schema.json
. You may also need to update these if you have added/removed new dependency type (e.g.pip
) or analysis target type (e.g.poetry
).