Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V.2: Planned roadway for version 2 #2168

Open
3 tasks
kushthedude opened this issue Nov 1, 2019 · 52 comments
Open
3 tasks

V.2: Planned roadway for version 2 #2168

kushthedude opened this issue Nov 1, 2019 · 52 comments
Labels
Open-for-all Parent issue V 2.0 This issue or PR is related to v.2 for Badgeyay.

Comments

@kushthedude
Copy link
Member

kushthedude commented Nov 1, 2019

For the development of V.2, TDD(Test Driven Development) approach should opt

  • Implement Django Server with API-Blueprint using Swagger or Apiary.
  • Implement ReactJS FrontEnd, Framework can be decided later on.
  • Implement CD and other Cloud Functions
@kushthedude
Copy link
Member Author

@iamareebjamal Your thoughts on the development life cycle.

@kushthedude kushthedude pinned this issue Nov 1, 2019
@kushthedude kushthedude added Open-for-all Parent issue V 2.0 This issue or PR is related to v.2 for Badgeyay. labels Nov 1, 2019
@codedsun
Copy link

codedsun commented Nov 1, 2019

@kushthedude I want to get involved also. let's move forward! Also, i would request to divide the major tasks with minor tasks(issues) so that everyone can take this and proceed.

@godcrampy
Copy link
Member

I'd like to work on the ReactJs part. I've sent a PR for the initial ReactJs setup.

@iamareebjamal
Copy link
Member

@godcrampy It'll be worked upon after development of backend

@iamareebjamal
Copy link
Member

@kushthedude First, let's list the feature requirement of the server to see what path should be taken

What should be the capability of the server? What features should it have at the end of development.

For example,

  1. Have an API for use with client apps which does following things
  2. Have a website with these facilities
  3. Have these features

@codedsun
Copy link

codedsun commented Nov 4, 2019

@kushthedude @iamareebjamal As we have done the initial setup of django, now when and how shall be the next step be done for discussing db model structure ?

@iamareebjamal
Copy link
Member

What models we had in previous app

@abishekvashok
Copy link
Member

Let me join in as well. Let's go forward.

@codedsun
Copy link

codedsun commented Nov 7, 2019

@iamareebjamal I am moving with creating basic login functionality

@iamareebjamal
Copy link
Member

What models we had in previous app?

First, we need to design the DB

@kushthedude
Copy link
Member Author

kushthedude commented Nov 7, 2019 via email

@iamareebjamal
Copy link
Member

That will be done progressively

@codedsun
Copy link

codedsun commented Nov 7, 2019

How we are going to design the DB? Either through a meeting, discussion or do I list the models used earlier in the app here? or design the DB as done earlier ?How we should proceed? @iamareebjamal

@iamareebjamal
Copy link
Member

List the models

@codedsun
Copy link

codedsun commented Nov 8, 2019

image

@iamareebjamal
Copy link
Member

And the columns?

@codedsun
Copy link

codedsun commented Nov 8, 2019 via email

@codedsun
Copy link

codedsun commented Nov 8, 2019

Table

  1. Badges
    image

  2. File
    image

  3. Modules
    image

  4. Permissions
    image

  5. Reset Password Token
    image

  6. Settings
    image

  7. SocialContent
    image

  8. User
    image

  9. Utilities
    image

@codedsun
Copy link

codedsun commented Nov 8, 2019

@iamareebjamal Done

@iamareebjamal
Copy link
Member

What do we want to retain from previous site?

@codedsun
Copy link

codedsun commented Nov 8, 2019

@kushthedude Please answer this, I am a beginner here.

@codedsun
Copy link

@iamareebjamal Please tell me how do I do this? I have not received any response till now. How do we move forward

@iamareebjamal
Copy link
Member

Add auth to new site for now

@kushthedude
Copy link
Member Author

kushthedude commented Nov 26, 2019 via email

@codedsun
Copy link

#2168 (comment)

@kushthedude Need your reply here for the models

@codedsun
Copy link

@kushthedude If you can help, finalising what we want to retain from previous site, we can move forward. Also let's see what @iamareebjamal says.

@championpaddler
Copy link
Member

@iamareebjamal I will also like to contribute.

@gabru-md
Copy link
Member

gabru-md commented Dec 2, 2019

Hi I'd like to join this discussion as well. In case you require some help regarding the previous site I'll be happy to provide the insight as much as I can.
😃

@codedsun
Copy link

codedsun commented Dec 3, 2019

@gabru-md Thanks a lot. We need to plan the models now. Please help me to get it done

@abishekvashok
Copy link
Member

We need to plan the models now. Please help me to get it done

What are the current plans?

@codedsun
Copy link

codedsun commented Dec 3, 2019

@gabru-md
Copy link
Member

gabru-md commented Dec 4, 2019

so for the models, we shall have to first identify what is needed to be stored in db. You have a snapshot of the previous model that we were running back when we first created badgeyay. What are the proposed plans that you plan on adding or removing?

@codedsun
Copy link

codedsun commented Dec 5, 2019

@gabru-md Yeah I added in the thread here about the models. @kushthedude Kindly tell us what models do we need here and what we want to retain from the previous site. So that we can move forward at a fast pace.

@codedsun
Copy link

codedsun commented Dec 7, 2019

@kushthedude If time allows please do make this task also proceed forward. Thanks

@maze-runnar
Copy link

@codedsun i think every thread from previous model should be collected to one place, is there any problem in using same fields as previous models have ?

@maze-runnar
Copy link

maze-runnar commented Jan 6, 2020

@codedsun when the next step would be finalize? i love to work on Django, So i want to be here more .

@codedsun
Copy link

codedsun commented Jan 7, 2020

@maze-runnar : I am stuck here #2168 (comment)

I have not worked with this previously so I dont' know the answer what to retain in the next.

@codedsun i think every thread from previous model should be collected to one place, is there any problem in using same fields as previous models have ?

The models are listed here

#2168 (comment)

@iamareebjamal @kushthedude - If we can take this forward it would be great 👍

@abishekvashok
Copy link
Member

User accounts to the minimum point, if it's not possible then we can proceed with a fresh start :)

@iamareebjamal
Copy link
Member

The point is that we can neither migrate old data nor start fresh unless someone knows the end goal of what it should look like, what are the features required, what is the roadmap. The points listed in this issue are vague and tech specific. We need specifications and end goal of the server. I don't know that and hence can't help move it forward unless someone else who knows the current project helps. I won't have enough time to dig through current project and see its nooks and crannies to port over. I can just comment on technical details on how to implement a certain functionality. I'm of no use if no one knows what functionality to develop

@abishekvashok
Copy link
Member

Okay, what we want is basically this:
A server API with minimal functionality of user authentication (again optional) and badge generation in Django. Then we can proceed with more options later.

A frontend to act as an interactive interface for the API in ReactJS

@abishekvashok
Copy link
Member

I can do this if no one can't do it :)

@maze-runnar
Copy link

@abishekvashok it was a part of the discussion #2176 (comment)
@iamareebjamal has said that we should go with Django templating as the project is not that UI intensive to use a separate frontend.

@PragatiVerma18
Copy link
Member

@kushthedude I would like to work on the Django part and would like to contribute a Users API that can help login/signup using Django Rest Framework, to begin with until the models are decided. After I have made the APIs, we can have the frontend integrated so that at least for beginning, login signup is functional, then we will keep adding features. Would that be a good plan to go with?

@iamareebjamal
Copy link
Member

We'll be using Django Templates, not separate frontend

@PragatiVerma18
Copy link
Member

PragatiVerma18 commented Jan 25, 2020

Okay, so are we not going to have the frontend and backend hosted to two different domains, we are just going to make a Django app inside our Django project for the backend and a separate folder for frontend? If so, we can use templated js snippets? Read about it here: hackernoon

@iamareebjamal
Copy link
Member

No JS needed for now. It's a pretty simple site. JS should be used for enhancements, like in github. The site you are writing this comment on is server side rendered and much better than any SPA I have used. What little enhancements they use JS for is fine. And wherever they use client-side rendering, it's always worse experience than server render. JS rendering should be used where you have highly dynamic UI and basically cannot do server render anyway - like infinite scrolling feeds in facebook/twitter with mariands of post types and dynamic media like picture albums/video. JS rendering anywhere else is not only unneeded but way poorer experience than server render. And then everyone still ends up rendering it on server using Next/Nuxt/Fastboot. Why go full circle and still do what we wanted to avoid in the first place, and in a much worse way?

@PragatiVerma18
Copy link
Member

Okay, I understand.

@siddhantvirus
Copy link

since there have been no updates since January is there anything could work on ? Either React or the CD and Cloud Part ?

@PragatiVerma18
Copy link
Member

@iamareebjamal @maze-runnar @kushthedude is there something to work on in Django or React? or are you going to continue with Ember and Flask? Please clarify the state of this project.

@iamareebjamal
Copy link
Member

Only Django. And our focus is not on the project right now https://gitter.im/fossasia/fossasia?at=5f78a76a6e0eb8446962511d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Open-for-all Parent issue V 2.0 This issue or PR is related to v.2 for Badgeyay.
Projects
None yet
Development

No branches or pull requests

10 participants