New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Forgot password on Firebase side #1000

Merged
merged 1 commit into from Jun 15, 2018

Conversation

@yashLadha
Copy link
Member

yashLadha commented Jun 13, 2018

Fixes #992

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • I have added necessary documentation (if appropriate)

Preview Link

Changes proposed in this pull request:

  • Implemented Forgot password on firebase side
  • Validated token from backend and displayed in frontend

PS : based on my previous PR.

@djmgit

This comment has been minimized.

Copy link
Member

djmgit commented Jun 14, 2018

@yashLadha please resolve conflicts.

@yashLadha

This comment has been minimized.

Copy link
Member

yashLadha commented Jun 14, 2018

On it @djmgit

@duttaditya18
Copy link
Member

duttaditya18 left a comment

Conflicts!

@yashLadha yashLadha force-pushed the yashLadha:reset-password3 branch from f4ec18a to 5f42095 Jun 14, 2018

@yashLadha

This comment has been minimized.

Copy link
Member

yashLadha commented Jun 14, 2018

Resolved it @djmgit Please review @ParthS007 @gabru-md

@yashLadha yashLadha force-pushed the yashLadha:reset-password3 branch from 5f42095 to f494df9 Jun 14, 2018

@open-event-bot open-event-bot bot removed the needs-review label Jun 14, 2018

@djmgit

djmgit approved these changes Jun 15, 2018

Copy link
Member

djmgit left a comment

Nice work 👍

@djmgit djmgit merged commit 0774c83 into fossasia:development Jun 15, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment