Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented Forgot password on Firebase side #1000

Merged
merged 1 commit into from Jun 15, 2018
Merged

Implemented Forgot password on Firebase side #1000

merged 1 commit into from Jun 15, 2018

Conversation

yashLadha
Copy link
Member

Fixes #992

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • I have added necessary documentation (if appropriate)

Preview Link

Changes proposed in this pull request:

  • Implemented Forgot password on firebase side
  • Validated token from backend and displayed in frontend

PS : based on my previous PR.

@djmgit
Copy link
Member

djmgit commented Jun 14, 2018

@yashLadha please resolve conflicts.

@yashLadha
Copy link
Member Author

On it @djmgit

nzec
nzec reviewed Jun 14, 2018
View reviewed changes
Copy link
Contributor

@nzec nzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts!

@yashLadha
Copy link
Member Author

Resolved it @djmgit Please review @ParthS007 @gabru-md

djmgit
djmgit approved these changes Jun 15, 2018
View reviewed changes
Copy link
Member

@djmgit djmgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

@djmgit djmgit merged commit 0774c83 into fossasia:development Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nzec nzec nzec left review comments

@djmgit djmgit djmgit approved these changes

@ParthS007 ParthS007 ParthS007 approved these changes

@gabru-md gabru-md gabru-md approved these changes

Assignees

@yashLadha yashLadha

Labels
ready-to-ship
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Created Forgot Password service using Firebase and Flask
5 participants
@yashLadha @djmgit @nzec @ParthS007 @gabru-md