Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1594 : Search functionality in admin by creator name #1617

Merged
merged 1 commit into from Aug 7, 2018

Conversation

@yashLadha
Copy link
Member

commented Aug 5, 2018

Fixes #1594

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • I have added necessary documentation (if appropriate)

Changes proposed in this pull request:

  • Search functionality in admin by creator name
@gabru-md
Copy link
Member

left a comment

can you provide a screenshot showing the search? or maybe a small video ? 😄

@open-event-bot open-event-bot bot removed the needs-review label Aug 5, 2018

</thead>
<tbody>
{{#each badges as |badge|}}
{{#if empty}}

This comment has been minimized.

Copy link
@abishekvashok

abishekvashok Aug 6, 2018

Member

I would be happy if you could properly align this

This comment has been minimized.

Copy link
@abhi40308

abhi40308 Aug 7, 2018

Member

I don't think there is indentation problem as codacy checks for linting errors :)

@ParthS007
Copy link
Member

left a comment

Can you please provide a video? else LGTM!

@abhi40308
Copy link
Member

left a comment

Please provide some screenshot, else LGTM 💯

@mariobehling mariobehling merged commit c9fdffa into fossasia:development Aug 7, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.