Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1594 : Search functionality in admin by creator name #1617

Merged
merged 1 commit into from Aug 7, 2018

Conversation

yashLadha
Copy link
Member

Fixes #1594

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • I have added necessary documentation (if appropriate)

Changes proposed in this pull request:

  • Search functionality in admin by creator name

Copy link
Member

@gabru-md gabru-md left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you provide a screenshot showing the search? or maybe a small video ? 😄

</thead>
<tbody>
{{#each badges as |badge|}}
{{#if empty}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be happy if you could properly align this

Copy link
Member

@abhi40308 abhi40308 Aug 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is indentation problem as codacy checks for linting errors :)

Copy link
Member

@ParthS007 ParthS007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please provide a video? else LGTM!

Copy link
Member

@abhi40308 abhi40308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide some screenshot, else LGTM 💯

@mariobehling mariobehling merged commit c9fdffa into fossasia:development Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sorting in badge tab by the name of creator
6 participants