Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix-1785 Adding Option to Simultaneously download multiple badges #1838

Merged
merged 1 commit into from Nov 10, 2018
Merged

Fix-1785 Adding Option to Simultaneously download multiple badges #1838

merged 1 commit into from Nov 10, 2018

Conversation

championpaddler
Copy link
Member

Fixes #1785

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • I have added necessary documentation (if appropriate)

Changes proposed in this pull request:

  • Adding Option to Simultaneously download multiple badges
    ezgif com-video-to-gif 23

@championpaddler
Copy link
Member Author

@ParthS007 @gabru-md Please review .

gabru-md
gabru-md reviewed Oct 20, 2018
View reviewed changes
Copy link
Member

@gabru-md gabru-md left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have a better colour for the download badge button?
and maybe a better position for the button as well?
cc: @ParthS007 @yashLadha

@championpaddler
Copy link
Member Author

Yup . Will do by tonight .

@championpaddler
Copy link
Member Author

championpaddler commented Oct 21, 2018 •
edited

@gabru-md Is this fine??
screenshot from 2018-10-21 12-35-25

@abishekvashok
Copy link
Member

Instead of moving the download button down, move it up above the line.

@championpaddler
Copy link
Member Author

It was already above line but @gabru-md suggested to place it to other position.

@abishekvashok
Copy link
Member

The left align is fine, but if you could move it up the bar, at the same x coordinate, it would be great

@championpaddler
Copy link
Member Author

@abishekvashok Ok

@championpaddler
Copy link
Member Author

screenshot from 2018-10-21 22-09-30
@abishekvashok @gabru-md Please review.

@championpaddler
Copy link
Member Author

@yashLadha @gabru-md @ParthS007 Please review .

gabru-md
gabru-md approved these changes Nov 1, 2018
View reviewed changes
Copy link
Member

@gabru-md gabru-md left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me
we can create a better UI for the same but currently we can just proceed ahead with this :)

@championpaddler
Copy link
Member Author

@ParthS007 Please review.

@championpaddler
Copy link
Member Author

@gabru-md This can be merged.

@ParthS007 ParthS007 merged commit a5f6004 into fossasia:development Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabru-md gabru-md gabru-md approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding Option to Simultaneously download multiple badges
4 participants
@championpaddler @abishekvashok @gabru-md @ParthS007