Fixes #723 : Greeting mail on user registration #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
May 11, 2018
backend/blueprint/api/models/user.py
Outdated
| @@ -28,3 +28,14 @@ def save_to_db(self): | |||
| @classmethod | |||
| def getUser(cls, username): | |||
| return cls.query.filter_by(username=username).first() | |||
|
|
|||
| @db.event.listens_for(User, "after_insert") | |||
Codecov Report
@@ Coverage Diff @@
## development #724 +/- ##
==========================================
Coverage 100% 100%
==========================================
Files 1 1
Lines 43 43
==========================================
Hits 43 43Continue to review full report at Codecov.
|
gabru-md
reviewed
May 11, 2018
backend/blueprint/api/models/user.py
Outdated
| msg['body'] = "It's good to have you onboard with Badgeyay. Welcome to " \ | ||
| "FOSSASIA Family." | ||
| res = send_mail(msg) | ||
| print(res) |
gabru-md
requested changes
May 11, 2018
backend/blueprint/api/utils/mail.py
Outdated
| @@ -1,17 +1,11 @@ | |||
| from flask_mail import Mail, Message | |||
| from flask import current_app as app | |||
| from flask import jsonify | |||
| from models.user import User | |||
| from .response import Response | |||
|
|
|||
|
|
|||
| def send_mail(message): | |||
There was a problem hiding this comment.
how about using camelCase and set the name to sendMail ?
backend/blueprint/api/models/user.py
Outdated
|
|
||
|
|
||
| @db.event.listens_for(User, "after_insert") | ||
| def send_verification(mapper, connection, target): |
There was a problem hiding this comment.
camelCase here as well, maybe?
houndci-bot
reviewed
May 11, 2018
backend/blueprint/api/models/user.py
Outdated
| msg['receipent'] = sav_user.username | ||
| msg['body'] = "It's good to have you onboard with Badgeyay. Welcome to " \ | ||
| "FOSSASIA Family." | ||
| res = sendMail(msg) |
There was a problem hiding this comment.
local variable 'res' is assigned to but never used
|
Done @gabru-md |
djmgit
reviewed
May 11, 2018
backend/blueprint/api/models/user.py
Outdated
|
|
||
| @db.event.listens_for(User, "after_insert") | ||
| def sendVerification(mapper, connection, target): | ||
| sav_user = target |
There was a problem hiding this comment.
Why are we not using target directly?
djmgit
reviewed
May 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes : #723
Checklist
developmentbranch.Preview Link
Changes proposed in this pull request: