Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed MariaDB/MySQL Support #49

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Removed MariaDB/MySQL Support #49

merged 3 commits into from
Mar 18, 2024

Conversation

Shivangi-ch
Copy link
Contributor

This PR fixes #29

Removed mysql/mariadb from dockerfile and requirements.
Added a condition to exit with code 1 if we try to start with mysql in config

PS: Their is one more PR which tries to solve the same issue but it misses some changes and is quite old without any activity, so I created this PR.

@Shivangi-ch
Copy link
Contributor Author

@hongquan can you please review this PR.

hongquan
hongquan requested changes Mar 15, 2024
View reviewed changes
src/pretix/settings.py Outdated Show resolved Hide resolved
hongquan
hongquan requested changes Mar 18, 2024
View reviewed changes
src/tests/travis_mysql.cfg Outdated Show resolved Hide resolved
@hongquan hongquan merged commit 3c0c683 into fossasia:master Mar 18, 2024
3 of 6 checks passed
weblate pushed a commit that referenced this pull request Apr 19, 2024
@Shivangi-ch @weblate
Removed MariaDB/MySQL Support (#49)
c47fc6a
weblate pushed a commit that referenced this pull request Apr 19, 2024
@Shivangi-ch @weblate
Removed MariaDB/MySQL Support (#49)
863d460
eMBee pushed a commit to eMBee/eventyay-tickets that referenced this pull request May 5, 2024
@Shivangi-ch
Removed MariaDB/MySQL Support (fossasia#49)
7c1ac88
eMBee pushed a commit to eMBee/eventyay-tickets that referenced this pull request May 6, 2024
@Shivangi-ch
Removed MariaDB/MySQL Support (fossasia#49)
19d7ca4
@mariobehling
Copy link
Member

Due to challenges with the previous branch merges, it would be easiest if you could make this PR again against the current development branch. Appreciate your effort!

eMBee pushed a commit to eMBee/eventyay-tickets that referenced this pull request May 20, 2024
@Shivangi-ch
Removed MariaDB/MySQL Support (fossasia#49)
bb21c04 
cleanup: remove remaining mysql code, patch up dependencies, fix typos (fossasia#53)

Co-authored-by: Martin Bähr <martin@codingforafrica.at>
eMBee pushed a commit to eMBee/eventyay-tickets that referenced this pull request May 21, 2024
@Shivangi-ch
Removed MariaDB/MySQL Support (fossasia#49)
74ac066 
cleanup: remove remaining mysql code, patch up dependencies, fix typos (fossasia#53)

Co-authored-by: Martin Bähr <martin@codingforafrica.at>
eMBee pushed a commit to eMBee/eventyay-tickets that referenced this pull request May 21, 2024
@Shivangi-ch
Removed MariaDB/MySQL Support (fossasia#49)
285fded 
cleanup: remove remaining mysql code, patch up dependencies, fix typos (fossasia#53)

Co-authored-by: Martin Bähr <martin@codingforafrica.at>
eMBee pushed a commit to eMBee/eventyay-tickets that referenced this pull request May 21, 2024
@Shivangi-ch
Removed MariaDB/MySQL Support (fossasia#49)
78ba783 
cleanup: remove remaining mysql code, patch up dependencies, fix typos (fossasia#53)

Co-authored-by: Martin Bähr <martin@codingforafrica.at>
eMBee pushed a commit to eMBee/eventyay-tickets that referenced this pull request May 21, 2024
@Shivangi-ch
Removed MariaDB/MySQL Support (fossasia#49)
9a19bbc 
cleanup: remove remaining mysql code, patch up dependencies, fix typos (fossasia#53)

Co-authored-by: Martin Bähr <martin@codingforafrica.at>
eMBee pushed a commit to eMBee/eventyay-tickets that referenced this pull request May 21, 2024
@Shivangi-ch
Removed MariaDB/MySQL Support (fossasia#49)
ce36586 
cleanup: remove remaining mysql code, patch up dependencies, fix typos (fossasia#53)

Co-authored-by: Martin Bähr <martin@codingforafrica.at>
eMBee pushed a commit to eMBee/eventyay-tickets that referenced this pull request May 21, 2024
@Shivangi-ch
Removed MariaDB/MySQL Support (fossasia#49)
ffdbac0 
cleanup: remove remaining mysql code, patch up dependencies, fix typos (fossasia#53)

Co-authored-by: Martin Bähr <martin@codingforafrica.at>
eMBee pushed a commit to eMBee/eventyay-tickets that referenced this pull request May 21, 2024
@Shivangi-ch
Removed MariaDB/MySQL Support (fossasia#49)
5390fb2 
cleanup: remove remaining mysql code, patch up dependencies, fix typos (fossasia#53)

Co-authored-by: Martin Bähr <martin@codingforafrica.at>
eMBee pushed a commit to eMBee/eventyay-tickets that referenced this pull request May 21, 2024
@Shivangi-ch
Removed MariaDB/MySQL Support (fossasia#49)
9f9175b 
cleanup: remove remaining mysql code, patch up dependencies, fix typos (fossasia#53)

Co-authored-by: Martin Bähr <martin@codingforafrica.at>
eMBee pushed a commit to eMBee/eventyay-tickets that referenced this pull request May 21, 2024
@Shivangi-ch
Removed MariaDB/MySQL Support (fossasia#49)
164f969 
cleanup: remove remaining mysql code, patch up dependencies, fix typos (fossasia#53)

Co-authored-by: Martin Bähr <martin@codingforafrica.at>
eMBee pushed a commit to eMBee/eventyay-tickets that referenced this pull request May 21, 2024
@Shivangi-ch
Removed MariaDB/MySQL Support (fossasia#49)
f9aa5c4 
cleanup: remove remaining mysql code, patch up dependencies, fix typos (fossasia#53)

Co-authored-by: Martin Bähr <martin@codingforafrica.at>
eMBee pushed a commit to eMBee/eventyay-tickets that referenced this pull request May 21, 2024
@Shivangi-ch
Removed MariaDB/MySQL Support (fossasia#49)
c67e595 
cleanup: remove remaining mysql code, patch up dependencies, fix typos (fossasia#53)

Co-authored-by: Martin Bähr <martin@codingforafrica.at>
eMBee pushed a commit to eMBee/eventyay-tickets that referenced this pull request May 21, 2024
@Shivangi-ch
Removed MariaDB/MySQL Support (fossasia#49)
17d070b 
cleanup: remove remaining mysql code, patch up dependencies, fix typos (fossasia#53)

Co-authored-by: Martin Bähr <martin@codingforafrica.at>
eMBee pushed a commit to eMBee/eventyay-tickets that referenced this pull request May 21, 2024
@Shivangi-ch
Removed MariaDB/MySQL Support (fossasia#49)
4b9f218 
cleanup: remove remaining mysql code, patch up dependencies, fix typos (fossasia#53)

Co-authored-by: Martin Bähr <martin@codingforafrica.at>
eMBee pushed a commit to eMBee/eventyay-tickets that referenced this pull request May 21, 2024
@Shivangi-ch
Removed MariaDB/MySQL Support (fossasia#49)
b290718 
cleanup: remove remaining mysql code, patch up dependencies, fix typos (fossasia#53)

Co-authored-by: Martin Bähr <martin@codingforafrica.at>
eMBee pushed a commit to eMBee/eventyay-tickets that referenced this pull request May 21, 2024
@Shivangi-ch
Removed MariaDB/MySQL Support (fossasia#49)
d328487 
cleanup: remove remaining mysql code, patch up dependencies, fix typos (fossasia#53)

Co-authored-by: Martin Bähr <martin@codingforafrica.at>
eMBee pushed a commit to eMBee/eventyay-tickets that referenced this pull request May 21, 2024
@Shivangi-ch
Removed MariaDB/MySQL Support (fossasia#49)
0132beb 
cleanup: remove remaining mysql code, patch up dependencies, fix typos (fossasia#53)

Co-authored-by: Martin Bähr <martin@codingforafrica.at>
eMBee pushed a commit to eMBee/eventyay-tickets that referenced this pull request May 21, 2024
@Shivangi-ch
Removed MariaDB/MySQL Support (fossasia#49)
3af0645 
cleanup: remove remaining mysql code, patch up dependencies, fix typos (fossasia#53)

Co-authored-by: Martin Bähr <martin@codingforafrica.at>
eMBee pushed a commit to eMBee/eventyay-tickets that referenced this pull request May 21, 2024
@Shivangi-ch
Removed MariaDB/MySQL Support (fossasia#49)
690e891 
cleanup: remove remaining mysql code, patch up dependencies, fix typos (fossasia#53)

Co-authored-by: Martin Bähr <martin@codingforafrica.at>
eMBee pushed a commit to eMBee/eventyay-tickets that referenced this pull request May 23, 2024
@Shivangi-ch
Removed MariaDB/MySQL Support (fossasia#49)
cefee9e 
cleanup: remove remaining mysql code, patch up dependencies, fix typos (fossasia#53)

Co-authored-by: Martin Bähr <martin@codingforafrica.at>
@eMBee eMBee mentioned this pull request May 23, 2024
Merged
mariobehling added a commit that referenced this pull request May 24, 2024
@eMBee @Shivangi-ch @mariobehling
Removed MariaDB/MySQL Support (#49) (#105)
b3a60d5 
cleanup: remove remaining mysql code, patch up dependencies, fix typos (#53)

Co-authored-by: Shivangi-ch <57783826+Shivangi-ch@users.noreply.github.com>
Co-authored-by: Martin Bähr <martin@codingforafrica.at>
Co-authored-by: Mario Behling <mb@mariobehling.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongquan hongquan hongquan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove MariaDB support
3 participants
@Shivangi-ch @mariobehling @hongquan