-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fine collision detection #71
Comments
I would like to work on this Issue. |
I would propose further changes for fine-grained collision detection: Context Proposals
Problems |
@niccokunzmann sounds like a great idea. But that needs that we need to change the existing obstacles. Also in inkscape we cant group a single item right. Wont that be a problem? |
@harry-7 I integrated your concerns into a new problems section. Do you agree? |
@niccokunzmann Yes . |
@harry-7 What would this look line on dom level? currently, we have, I believe
|
@niccokunzmann In the level we have the groups with the group will also come as obstacle so we do unnecessary checks. How ever if we do some thing like this it will be good
Then we will be able to do the collision checks efficiently. |
What is the goal you want to achieve? You wrote "better" or "good". How would you measure it. More context: obstacles are grouped in layers. Once a layer is used as an obstacle, child of it becomes an obstacle. In case your goal is to make collision detection finer than ABBA with the whole group, this would be to me that we look into the group. I do not understand how adding a obstacle class improves collision detection. |
@niccokunzmann By good I mean it will reduce unnecessary collision checks we make. I ll add class to the most fundamental part of the obstacle. the child which no more has any groups in it.
Does this make sense ? |
If we add a class, this must also be easy to do in Inkscape. We access child elements if zou look here Am 30.07.2016 um 17:28 schrieb Hemanth Kumar Veeranki:
|
@harry-7 Could you help me analyze the situation, so we can make sure we talk about the same? I also loose track when the conversation gets longer. I would split up the problem like this:
Can you split up the problem into more questions? Then, we can refer to them and tackle the separately. This can help me not getting confused. |
@niccokunzmann I think those will be enough. We currently have the idea of the third topic. My suggestion of adding a class to all obstacles will help in 1 and 2.Coming to issue 4 we can proceed to implement collision to detect each obstacle object instead of whole group as you mentioned here
|
(3) Given that we know the boundary of the obstacle, the term for this collision detection is "polygon intersection". We do not need an algorithm that computes the polygon intersection, we just need one that tells us if there is a polygon intersection. Implemented e.g. by this library there may be others for JavaScript. |
@niccokunzmann We already have implemented the collision for rect's right. I don't get the idea why we need a polygon collision. |
I do not require polygon collision to be implemented. I would like to Evaluation: Am 05.08.2016 um 09:58 schrieb Hemanth Kumar Veeranki:
|
@harry-7 updates |
Currently, we have a collision detection that checks the rectangle of the obstacle. This leads to a lot of hits even if there are no. See #4 for suggestions.
The new collision detection reduces the number of wrong hits. Comment if you would like to do this.
The text was updated successfully, but these errors were encountered: