Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added update error message #33

Merged
merged 4 commits into from
Jan 12, 2016
Merged

Added update error message #33

merged 4 commits into from
Jan 12, 2016

Conversation

antoniomdk
Copy link
Contributor

No description provided.

@niccokunzmann
Copy link
Member

Please always reference the issue if it has something to do with it. What did you update? Maybe that could have been in the commit message. Now, I can only guess or must look at the source code.

@niccokunzmann
Copy link
Member

Thanks for the apk.

@antoniomdk
Copy link
Contributor Author

Ok, sorry. If threre is any problem with the app, tell me.

@antoniomdk antoniomdk closed this Jan 12, 2016
@antoniomdk antoniomdk reopened this Jan 12, 2016
@antoniomdk
Copy link
Contributor Author

I have added a progress bar and some message. #32

niccokunzmann
niccokunzmann reviewed Jan 12, 2016
View reviewed changes
FlappySVG_Android/app/src/main/java/fossasia/flappysvg/GameActivity.java
new DownloadTask().execute(download_file_path);
if (isThereAPreviousVersion()) {
Log.d("Loading Game", local_game_path);
myWebView.loadUrl("file:///" + local_game_path);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating while loading the files form the web view creates possible race-conditions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, that code is deleted. The app checks if there is local game, and if it is true, the app load it. If it is not true, the app downloads the game. And if you are playing and you update the game, the app reloads the webview.

@niccokunzmann
Copy link
Member

I can still understand the code. It looks like it would do as expected. I will test the app as soon as I get the device back.

@antoniomdk
Copy link
Contributor Author

Perfect!. I am working in the description but it is not ready yet. I have a question. How Do I have to orient the description? as an open source game o as a GCI project?

@niccokunzmann
Copy link
Member

I would say it is an open source project, which is true, see license and open code. I would not use the word but rather describe what it means, since the audience may not be familiar with this term.
Something like: You can create own characters and levels and there is guidance by a community. People developed this game who are just like you.

  • Something in this sense.
    You can write about google code-in. The objective - I would propose - is to create appetite to try the game and start developing it.

@antoniomdk
Copy link
Contributor Author

Perfect, I am going to use that. Thanks.

niccokunzmann added a commit that referenced this pull request Jan 12, 2016
@niccokunzmann
Merge pull request #33 from antoniomdk/gh-pages
ffb763f 
Added update error message
@niccokunzmann niccokunzmann merged commit ffb763f into fossasia:master Jan 12, 2016
@niccokunzmann
Copy link
Member

I tested it and it works. Very good.

@antoniomdk
Copy link
Contributor Author

Perfect. If there is any problem, tell me.

@niccokunzmann niccokunzmann mentioned this pull request Jan 13, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@antoniomdk @niccokunzmann